search

SketchUp / sketchup-stl

A SketchUp Ruby Extension that adds STL (STereoLithography) file format import and export.
http://extensions.sketchup.com/content/sketchup-stl
MIT License
248 stars 68 forks source link

remove dxf-specific methods and options #37

Closed jimfoltz closed 12 years ago

jimfoltz commented 12 years ago

Cleanup & Reorg.

jimfoltz commented 12 years ago

Good point. An Exporter class would be more consistent. Will add.

thomthom commented 12 years ago

I was thinking module. The Importer needed a class due to the Importer API. Exporter doesn't have that, so I don't see any use in a class.

Sendt fra min Xperia™-smarttelefon

Jim Foltz notifications@github.com:

Good point. An Exporter class would be more consistent. Will add.

Reply to this email directly or view it on GitHub: https://github.com/SketchUp/sketchup-stl/pull/37#issuecomment-10038661

jimfoltz commented 12 years ago

I guess I'll be learning about merge conflicts next. Any tips?

thomthom commented 12 years ago

With tortoise Hg there is a nice merge tool that gives you a three-way view of files to merge. don't remember the name of it. But having a tool to visualize like that makes the process much easier.

scottlininger commented 12 years ago

You might want to make a local backup of your files in case you want to revert easily. Other than that, just dive in.

Sorry, I really should have merged your changes first, then Brian's. That would have been easier to handle, I think.

jimfoltz commented 12 years ago

I really dislike the 80 column limit. Other than that, things are going swell.

jimfoltz commented 12 years ago

Close? What did I do? I thought I was closing the comment box or something.

Should I re-open it?

thomthom commented 12 years ago

What line length do you usually use?

jimfoltz commented 12 years ago

What line length do you usually use?

I don't have a set number, I use common sense. I just find arbitrary line-breaks distracting when there's not a logical reason behind it. An 80 column limit isn't logical to me because it forces a break where there need not be one. Why shouldn't we be able to use the other half of our screens? Am I the only one who codes full-screen?

(The red, vertical line is at 80 columns.)

All of them

thomthom commented 12 years ago

Readability of text decreases as lines get too long. 60 - 80 is generally optimal for reading.

As for the other part of the screen, I always use split screen. In Sublime and Notepad++.

Split Screen Setup

scottlininger commented 12 years ago

The 80 column limit is an endless debate. The reason I like it is legibility in even the most limited environment.

jimfoltz commented 12 years ago

The 80 column limit is an endless debate. The reason I like it is legibility in even the most limited environment.

I'm going with it - constraints can force a different perspective. I'm here to learn.