search

SketchUp / sketchup-stl

A SketchUp Ruby Extension that adds STL (STereoLithography) file format import and export.
http://extensions.sketchup.com/content/sketchup-stl
MIT License
248 stars 68 forks source link

update .rbz installer #63

Closed Aerilius closed 11 years ago

Aerilius commented 11 years ago

We should maybe think about compiling a new .rbz installer (and also where to host it in case the repo would increase too much in size). The one we currently have (1.0.0) still spreads the bug that thomthom fixed in 2889768a626c8ba91a31df6be3b149bdb7c8395f and fails for all users who have no up-to-date SketchUp. (Of course letting them update SketchUp is a nice option as well :grinning: , but it's not obvious and the error is an unpleasant experience, and we target wider compatibility than just SU8M4+) (Or is there any major release date in sight?)

scottlininger commented 11 years ago

A new rbz would be great.

thomthom commented 11 years ago

Especially since this blog post: http://sketchupdate.blogspot.no/2013/01/stls-for-3d-printing-in-and-out-of.html

thomthom commented 11 years ago

@jimfoltz you fixed some things as well, such as a bug in my cleanup code when the geometry was not imported into a group.

Can we merge and apply this before releasing an update?

jimfoltz commented 11 years ago

I made a pull request with only the fix but none of the other changes in the series. Not sure what I was doing in my master branch.. :confused:

thomthom commented 11 years ago

What about the other stuff? You don't want to include that?

jimfoltz commented 11 years ago

I only included a bug fix so a new rbz could be generated. I am not sure it's the right time for adding in-progress (un-tested) features.

scottlininger commented 11 years ago

Seems like I should merge the bug fix, then we can consider other changes on other requests. Any objections?

thomthom commented 11 years ago

How are we doing this update? Add a new RBZ in the repo itself? Or upload it a place where it can be downloaded?

scottlininger commented 11 years ago

I'd say replace the .rbz in the repo root with a new one, probably with a new revision number, like sketchup-stl-1.0.1.rbz

We'd want to rev the extension version, too.

thomthom commented 11 years ago

How's the version numbers set?

I've always seen versions like:

Major number: increment for major feature change, addition or core rewrite Minor number: Feature added or improved Revision number: small bug fixes.

I'd say this is at least 1.1.0 - could have been version 2.0 due to pretty much complete rewrite and wrapped up in a new namespace. But we have a few unresolved issues where I'd imagined we'd complete before calling it a 2.0.

I set up some milestones a couple of weeks ago. Be interesting to hear what you lot think.

Just nobody say we do versions like Firefox or Chrome...

scottlininger commented 11 years ago

Good points. I'd say this is 1.1.0, and a candidate for 2.0.0. We probably should scrub the feature request list and see what belongs in a 2.0.0 release.

thomthom commented 11 years ago

My suggestion for Milestone 2.0: https://github.com/SketchUp/sketchup-stl/issues?milestone=1&state=open

And 2.1: https://github.com/SketchUp/sketchup-stl/issues?milestone=2&state=open

Aerilius commented 11 years ago

Oh, and people start hard-linking to the 1.0.0 file.

thomthom commented 11 years ago

Ok, Jim's fix is now merged. Would have been nice to have #54 fixed as well though.