search

SketchUp / sketchup-stl

A SketchUp Ruby Extension that adds STL (STereoLithography) file format import and export.
http://extensions.sketchup.com/content/sketchup-stl
MIT License
248 stars 68 forks source link

heal_geometry function bug #77

Closed HumbertoRB closed 11 years ago

HumbertoRB commented 11 years ago

Hi,

I've recently upgraded the "old" jf_stl_importer with the current sketchup-stl verions and in my tests discovered a bug in the heal_geometry function.

This is the original STL: originalstlfile

And what happens in the import with and without the heal_geometry function working: heal_geometry effect

The original STL can be dowloaded from: http://www.sendspace.com/file/fp8bal

I'm available for further testing and/or any assistance in narrowing further the problem.

PS: good job with the importer BTW. Cheers HB

thomthom commented 11 years ago

huh! That's most peculiar.

I'll look into what's causing that.

(Btw, sendspace contained quite a lot of misleading advertising, fake download buttons and fake system warnings. I'd recommend you found a different service to share files. I personally use dropbox.)

thomthom commented 11 years ago

Found the cause, fixed it, created a pull request. Should be packaging a new version soon.

HumbertoRB commented 11 years ago

Great! I'll look for it and test on my setup. Thanks

HumbertoRB commented 11 years ago

Checked: It is working fine. Thanks again.

thomthom commented 11 years ago

I'm reopening it because the fix haven't been peer reviewed and merged with this main repository yet. (Just for our internal organization.)

HumbertoRB commented 11 years ago

OK