Sketchware-Pro / Sketchware-Pro

Sketchware Pro's sources in Java. Now anyone can contribute to Sketchware Pro.
https://sketchware.pro
Other
862 stars 254 forks source link

M3: `MenuItem#setIconTintList` called on API levels < 26 #1036

Open JavkhlanK opened 5 months ago

JavkhlanK commented 5 months ago

Describe the bug See title. Only in material-redesign builds.

To Reproduce Steps to reproduce the behavior:

  1. Open any Event on a device with API level < 26

Expected behavior No crash

Device and Sketchware Pro-related info:

Additional context Continuation of #1035

rexfernandezluciano commented 1 month ago

Haven't fixed yet?

JavkhlanK commented 1 week ago

Definitely not. Just look at this: https://github.com/Sketchware-Pro/Sketchware-Pro/blob/material-redesign/app/src/main/java/com/besome/sketch/editor/LogicEditorActivity.java#L1956

remaker17 commented 1 week ago

I think, we need to use drawable selectors there instead. e.g: res/drawable/selector_save_tinted.