search

Sketchware-Pro / Sketchware-Pro

Sketchware Pro's sources in Java. Now anyone can contribute to Sketchware Pro.
https://sketchware.pro
Other
874 stars 259 forks source link

Use default view editor theme #1127

Closed elfilibusterismo closed 2 weeks ago

elfilibusterismo commented 2 weeks ago

This changes will prevent from using material3 in the view editor

remaker17 commented 2 weeks ago

Hello, good pull request. Can you use Theme.MaterialComponents.Light.Bridge as parent theme?

Source: Parent theme from main branch.

elfilibusterismo commented 2 weeks ago

Hello, good pull request. Can you use Theme.MaterialComponents.Light.Bridge as parent theme?

Source: Parent theme from main branch.

I can do that but some widget or specifically FloatingActionButton in editor will still use the box shape.. tho i can use @style/Widget.MaterialComponents.FloatingActionButton in it to make it circle shape

remaker17 commented 2 weeks ago

Hello, good pull request. Can you use Theme.MaterialComponents.Light.Bridge as parent theme?

Source: Parent theme from main branch.

I can do that but some widget or specifically FloatingActionButton in editor will still use the box shape.. tho i can use @style/Widget.MaterialComponents.FloatingActionButton in it to make it circle shape

It is weird that some styles remained from the Material3 theme.

elfilibusterismo commented 2 weeks ago

Hello, good pull request. Can you use Theme.MaterialComponents.Light.Bridge as parent theme? Source: Parent theme from main branch.

I can do that but some widget or specifically FloatingActionButton in editor will still use the box shape.. tho i can use @style/Widget.MaterialComponents.FloatingActionButton in it to make it circle shape

It it weird that some styles remained from the Material3 theme.

Yeah, that's why I didn't use .Bridge

remaker17 commented 2 weeks ago

@ilyassesalama can you check this pr?

ilyassesalama commented 2 weeks ago

LGTM