Sketchware-Pro / Sketchware-Pro

Sketchware Pro's sources in Java. Now anyone can contribute to Sketchware Pro.
https://sketchware.pro
Other
863 stars 254 forks source link

Unknown bug #398

Closed Arashvscode closed 2 years ago

Arashvscode commented 2 years ago

Screenshot_۲۰۲۲۰۵۱۵-۲۲۴۰۰۰_Sketchware Pro I downloaded the latest action, and when I run the program, it always shows me a message to create a res folder in the local libraries, while in previous versions this message was never displayed to me.

khaled-0 commented 2 years ago

And how is this a bug? It's literally on the message that what's going on

JavkhlanK commented 2 years ago

@khaled-0, look at the path, it's about built-in libraries. That's not supposed to happen, though one could achieve that by using a Developer Tools option.

Can you try clearing the app cache, and if that doesn't work, the app data?

Arashvscode commented 2 years ago

This is strange for local libraries

khaled-0 commented 2 years ago

So for some reason it expects built in libraries in data/data/...cache/libs/libs/ Manually copying all built in libs there fixes the issue. But it shouldn't do that in the first place

JavkhlanK commented 2 years ago

Some? That's intended, see commit ebbc8f4af6ba5746319948520e021e8696907163. I'm sure it's also extracting built-in libraries to that location, since it worked on my device. I'm guessing this is another bug similar to the older …/res not found bug, where the ZIP file wasn't fully readable by some devices.

khaled-0 commented 2 years ago

Some? That's intended, see commit ebbc8f4. I'm sure it's also extracting built-in libraries to that location, since it worked on my device. I'm guessing this is another bug similar to the older …/res not found bug, where the ZIP file wasn't fully readable by some devices.

What's the point if you have all the libs extracted in data/data/sk.../files/libs/libs Why copy it over to cache?

khaled-0 commented 2 years ago

Wait no, so for some reason it doesn't try to extract the libs after first time

JavkhlanK commented 2 years ago

They aren't getting copied over to the cache directory, but instead, getting extracted there.

Since deleting those files isn't fatal and Sketchware Pro can extract them again on its own, using the cache directory is better, for example for users who want to quickly make some storage space free.

khaled-0 commented 2 years ago

They aren't getting copied over to the cache directory, but instead, getting extracted there.

Since deleting those files isn't fatal and Sketchware Pro can extract them again on its own, using the cache directory is better, for example for users who want to quickly make some storage space free.

That's the thing After clearing cache Or whatever It extracts aapt2 and creates a compiledLibs dir But it doesn't extract the libs again

khaled-0 commented 2 years ago

Screenshot_20220516-221735403 Resulting in this. But it doesn't show the following dialog anymore for me.

JavkhlanK commented 2 years ago

wait bruh lol

JavkhlanK commented 2 years ago

Must be because dexs.zip and libs.zip still get extracted to filesDir, not cacheDir.

khaled-0 commented 2 years ago

Must be because dexs.zip and libs.zip still get extracted to filesDir, not cacheDir.

No They just don't get extracted at all. Not even in the files dir

And it just instantly completes the Extracting part when building

JavkhlanK commented 2 years ago

Weird, they did for me after I deleted the entire libs folder in the files directory.

JavkhlanK commented 2 years ago

Should have been fixed with 6bc31f7e8d97a896bd1fcff0a0883864837e94d0.

khaled-0 commented 2 years ago

Even tho it's marked as fixed and it works I still couldn't replicate the same dialog anymore It only showed once randomly in my testings. Meh I hope it's the same issue and got fixed

Arashvscode commented 2 years ago

Tnks jbk0