search

Sketchware-Pro / Sketchware-Pro

Sketchware Pro's sources in Java. Now anyone can contribute to Sketchware Pro.
https://sketchware.pro
Other
862 stars 254 forks source link

FEAT: Async Shell Script Execution whenever Sketchware Starts #538

Closed 1tsMeMario closed 2 months ago

1tsMeMario commented 1 year ago

Run a custom shell script whenever you start sketchware. Can be used for restoration or backup purposes or if you are advanced in shell scripting then whatever you can think of.

1tsMeMario commented 1 year ago

Setting is in Mod Settings, by default it is turned off. Root and non-root users can use this script. Must manually create the script in root of Internal Storage. Name file sketchwarescript.sh

ilyassesalama commented 9 months ago

It's been almost a year now. @1tsMeMario will you make any changes to this pull request anytime soon?

JavkhlanK commented 9 months ago

It's been almost a year now. @ 1tsMeMario will you make any changes to this pull request anytime soon?

though I don't see this feature be useful for many people. Don't automatization apps already provide app launches as triggers? For example, Automate already has such a thing.

1tsMeMario commented 9 months ago

yall never wanted to approve it, thats on yall. i gave up on it on the public end and just improved it on my end only.

On Fri, Aug 11, 2023, 5:08 PM Javkhlan K. @.***> wrote:

It's been almost a year now. @ 1tsMeMario will you make any changes to this pull request anytime soon?

though I don't see this feature be useful for many people. Don't automatization apps already provide app launches as triggers? For example, Automate already has such a thing.

— Reply to this email directly, view it on GitHub https://github.com/Sketchware-Pro/Sketchware-Pro/pull/538#issuecomment-1675456360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV2UGZKA56WW73HURHQXI5DXU2UODANCNFSM56RDRDTA . You are receiving this because you were mentioned.Message ID: @.***>

ilyassesalama commented 9 months ago

@1tsMeMario As long as this pull request is active, we're still waiting for your changes. We love people who contribute to making Sketchware Pro even better. However, any contribution must be thoroughly reviewed before merging it to make sure it won't affect our users. You know, they have projects that must stay safe and we're responsible for that.

The last thing you said is "the pallete part ill change it back lol i just thought it was a spelling error sorry". So, we're waiting for your change to merge this pull request. You didn't even get back to us about this pull request. We would have clarified what is wrong/should be done.

Again, we're waiting for your changes, and why not some new awesome contributions in the future? Thanks for the time you've spent contributing to Sketchware Pro.