Sketchware-Pro / Sketchware-Pro

Sketchware Pro's sources in Java. Now anyone can contribute to Sketchware Pro.
https://sketchware.pro
Other
863 stars 254 forks source link

Compress .mp3 when converting to .aab #596

Closed yusufquteb closed 1 year ago

yusufquteb commented 1 year ago

I have an application which have many mp3 files in asset After converting to apk runs normally After converting to aab no sound plays

JavkhlanK commented 1 year ago

Which exact Sketchware Pro version did you use, e.g. v6.4.0-rc01?

yusufquteb commented 1 year ago

Which exact Sketchware Pro version did you use, e.g. v6.4.0-rc01?

v6.4.0-rc04

JavkhlanK commented 1 year ago

Is there any specific error message you're getting in the app or something? Could you maybe share an AAB and APK of that project?

yusufquteb commented 1 year ago

Is there any specific error message you're getting in the app or something? Could you maybe share an AAB and APK of that project?

No errors appears ,just no sounds plays I searched the web They say must add this line to build.gradle

aaptOptions{ noCompress "mp3" }

I don't know how to share files here

JavkhlanK commented 1 year ago

Anything related to build.gradle isn't related to Sketchware and Sketchware Pro. They don't use Gradle to build projects.

What tool did you use to convert that AAB into a usable file? I feel like I once saw a report complaining about an AAB "bug" that should actually have been caused by the conversion app.

You could upload files to e.g. MediaFire and just paste the link in here.

yusufquteb commented 1 year ago

Anything related to build.gradle isn't related to Sketchware and Sketchware Pro. They don't use Gradle to build projects.

What tool did you use to convert that AAB into a usable file? I feel like I once saw a report complaining about an AAB "bug" that should actually have been caused by the conversion app.

You could upload files to e.g. MediaFire and just paste the link in here.

I use sketchware rc04 to convert to aab

JavkhlanK commented 1 year ago

I meant the app you used to convert the AAB to e.g. an APK.

yusufquteb commented 1 year ago

I meant the app you used to convert the AAB to e.g. an APK.

App bundle installer Or Apk Abb converter

JavkhlanK commented 1 year ago

Can you share the AAB file and output APK file so that I can have a look at them?

yusufquteb commented 1 year ago

Can you share the AAB file and output APK file so that I can have a look at them?

Iam uploading right now

yusufquteb commented 1 year ago

Can you share the AAB file and output APK file so that I can have a look at them?

Iam uploading right now

Apk file

https://t.me/mynationdreams/10

Aab file

https://t.me/mynationdreams/11

JavkhlanK commented 1 year ago

Thanks, will look at them now.

yusufquteb commented 1 year ago

Thanks, will look at them now.

Thank you bro🥰

yusufquteb commented 1 year ago

Thanks, will look at them now.

This link in google play

https://play.google.com/store/apps/details?id=firstwords.mynationdreams

JavkhlanK commented 1 year ago

Just checked, and in the AAB those asset files are compressed somehow. Gonna investigate further.

yusufquteb commented 1 year ago

Just checked, and in the AAB those asset files are compressed somehow. Gonna investigate further.

Tank you for helping 🌹

shapun963 commented 1 year ago

you need to use             Config$Compression#addAllUncompressedGlob(extensions to not compress) inorder to not compress it.

yusufquteb commented 1 year ago

you need to use             Config$Compression#addAllUncompressedGlob(extensions to not compress) inorder to not compress it.

How?

shapun963 commented 1 year ago

you need to use             Config$Compression#addAllUncompressedGlob(extensions to not compress) inorder to not compress it.

How?

You cant change on your end .It must be changed in sk pro.

JavkhlanK commented 1 year ago

you need to use Config$Compression#addAllUncompressedGlob(extensions to not compress) inorder to not compress it.

Thanks, I'll try to use that to add already not compressed files in the main module archive to the uncompressed list.

About 14 hours ago I found out that adding --uncompressed to the bundletool cmdline fixed the compression issue, and that the main module archive created by Sketchware Pro had asset files uncompressed. I couldn't share that here though, I fell asleep during my break lmao

yusufquteb commented 1 year ago

you need to use Config$Compression#addAllUncompressedGlob(extensions to not compress) inorder to not compress it.

Thanks, I'll try to use that to add already not compressed files in the main module archive to the uncompressed list.

About 14 hours ago I found out that adding --uncompressed to the bundletool cmdline fixed the compression issue, and that the main module archive created by Sketchware Pro had asset files uncompressed. I couldn't share that here though, I fell asleep during my break lmao

Can you share it with me? Can't move on in my app

JavkhlanK commented 1 year ago

you need to use Config$Compression#addAllUncompressedGlob(extensions to not compress) inorder to not compress it.

Thanks, I'll try to use that to add already not compressed files in the main module archive to the uncompressed list. About 14 hours ago I found out that adding --uncompressed to the bundletool cmdline fixed the compression issue, and that the main module archive created by Sketchware Pro had asset files uncompressed. I couldn't share that here though, I fell asleep during my break lmao

Can you share it with me? Can't move on in my app

No, please wait for the bug to be fixed properly.

JavkhlanK commented 1 year ago

I could have fixed this bug with commit 70e0a87b1c80bf4c0c62ae38735d0019918a13cd. Can you try it out using this snapshot build?

yusufquteb commented 1 year ago

I could have fixed this bug with commit 70e0a87. Can you try it out using this snapshot build?

Thank you bro .you fixed it🌹

JavkhlanK commented 1 year ago

That's nice. Thanks for mentioning the bundletool API, @shapun963!