Sketchware-Pro / Sketchware-Pro

Sketchware Pro's sources in Java. Now anyone can contribute to Sketchware Pro.
https://sketchware.pro
Other
863 stars 254 forks source link

Implement R8 shrinker #720

Closed PranavPurwar closed 10 months ago

PranavPurwar commented 1 year ago

Looks all-in-all neat, but to me, having R8/ProGuard in Build Settings is a bad UI decision. I think it should be adjustable in ProGuard Manager instead.

I did this in a hurry, didn't really think of that.

JavkhlanK commented 1 year ago

bro sir what happened in the last commit

ilyassesalama commented 1 year ago

Looks all-in-all neat, but to me, having R8/ProGuard in Build Settings is a bad UI decision. I think it should be adjustable in ProGuard Manager instead.

To be honest, the whole build dialog is a bad UI decision. IMO, when the user clicks on "build settings" button, an activity should appear showing all possible toggles or modifications that can be made, and even shortcuts to take you to specific activities such as ProGuard settings.

You may ask, why I have chosen an activity? It is because the current UI has become so crowded, and future features will not fit there well. So, it's better to take a step ahead to solve this issue permanently. You may also ask, how would the activity look? In my opinion, I think it should look like AndroidManifest Manager screen.

DereckySany commented 1 year ago

Looks all-in-all neat, but to me, having R8/ProGuard in Build Settings is a bad UI decision. I think it should be adjustable in ProGuard Manager instead.

To be honest, the whole build dialog is a bad UI decision. IMO, when the user clicks on "build settings" button, an activity should appear showing all possible toggles or modifications that can be made, and even shortcuts to take you to specific activities such as ProGuard settings.

You may ask, why I have chosen an activity? It is because the current UI has become so crowded, and future features will not fit there well. So, it's better to take a step ahead to solve this issue permanently. You may also ask, how would the activity look? In my opinion, I think it should look like AndroidManifest Manager screen.

in my opinion, "build settings" should stay the way it is offering unique and quick options to be adjusted, and not creating an activity full of options that already exist in their own sections,for advanced sections we have the drawer on the right, last position where you can add anything for advanced controls,without messing up the sketchware interface that everyone is used to.

PranavPurwar commented 1 year ago

merge now

moderGamer commented 1 year ago

Hi, does this feature encrypt the project like ProGuard?

PranavPurwar commented 1 year ago

Hi, does this feature encrypt the project like ProGuard?

@moderGamer yes, but its much more efficient and better

moderGamer commented 1 year ago

Very good, so fix the error so that it is added to the new sketchware feature, thank you

PranavPurwar commented 1 year ago

Very good, so fix the error so that it is added to the new sketchware feature, thank you

@moderGamer its the upstream changes causing issue

moderGamer commented 1 year ago

Very good, so fix the error so that it is added to the new sketchware feature, thank you

@moderGamer its the upstream changes causing issue

Good luck building this feature

moderGamer commented 1 year ago

Screenshot_20230221-232225_Dexter

@PranavPurwar Hello are you feeling good? I tested the last action and created a program, as you can see in the photo, it did not block a specific code. Can you explain a little about this feature, thanks?

PranavPurwar commented 1 year ago

@moderGamer did you enable proguard in settings?

moderGamer commented 1 year ago

no bro

remaker17 commented 1 year ago

Screenshot_20230222-112759.jpg

PranavPurwar commented 1 year ago

no bro

you need to enable that to start the shrinker

PranavPurwar commented 1 year ago

Screenshot_20230222-112759.jpg

Are you on less than API 26 device?

moderGamer commented 1 year ago

Screenshot_20230222-112759.jpg

Are you on less than API 26 device?

Screenshot_20230222-092644_Sketchware Pro

is active

remaker17 commented 1 year ago

Screenshot_20230222-112759.jpg

Are you on less than API 26 device?

No, I have a device with the 30 api version.

moderGamer commented 1 year ago

my android version 11

@TheRemakerMan

remaker17 commented 1 year ago

my android version 11

@TheRemakerMan

I didn't talk to you, bruh.

PranavPurwar commented 1 year ago

@TheRemakerMan you downloaded the minApi21 variant, its only available on minApi26 variant due to NIO dependency of R8/D8

remaker17 commented 1 year ago

@TheRemakerMan you downloaded the minApi21 variant, its only available on minApi26 variant due to NIO dependency of R8/D8

Oh, thanks.

moderGamer commented 1 year ago

@TheRemakerMan you downloaded the minApi21 variant, its only available on minApi26 variant due to NIO dependency of R8/D8

I also installed the same version, it does not lock a special code

PranavPurwar commented 1 year ago

@moderGamer Enable proguard from the drawer and enable R8 from build settings dialog and build the project

moderGamer commented 1 year ago

Aha ok bro tnks to Help me