search

Sketchware-Pro / Sketchware-Pro

Sketchware Pro's sources in Java. Now anyone can contribute to Sketchware Pro.
https://sketchware.pro
Other
863 stars 254 forks source link

feat : Project compiling notification. #803

Closed devkumar00001 closed 9 months ago

devkumar00001 commented 1 year ago

XRecorder_10032023_131819 XRecorder_10032023_131947

khaled-0 commented 1 year ago

Well it's not actually building in the background the activity/build may get killed by system when you're on background because the build process is actually not in background thread/service

So this doesn't matter

devkumar00001 commented 1 year ago

Well it's not actually building in the background the activity/build may get killed by system when you're on background because the build process is actually not in background thread/service

So this doesn't matter

I mean to say that when Sketchware is not open in foreground it is paused for building app so notification will only appear when app is not foreground.

devkumar00001 commented 1 year ago

fixed error : error

devkumar00001 commented 1 year ago

Trying to fix : Error

DereckySany commented 1 year ago

I liked the addition. but I see no reason to use androidx.core.app.NotificationCompat.Builder I prefer to use the native libraries as much as possible, so as not to generate incompatibility or the use of one more library, and you can use Notification.Builder natively.

devkumar00001 commented 1 year ago

I liked the addition. but I see no reason to use androidx.core.app.NotificationCompat.Builder I prefer to use the native libraries as much as possible, so as not to generate incompatibility or the use of one more library, and you can use Notification.Builder natively.

IMG_20230412_103023 But it working on Api-23 and I am not sure but it will work on lower devices also.

devkumar00001 commented 1 year ago

It only have one bug that I can't fix is If the project is running and app get destroyed from recent screen it will keep showing a notification.

devkumar00001 commented 1 year ago

I don't think sending notifications about build status while the actual build process itself isn't guaranteed to not get killed (or at least given higher importance than other apps) while it's not in the foreground is worth implementing. It could actually make users believe the app can compile in the background, and then think compiling stopping while multi-tasking being a bug.

Then it was better earlier that it only shows notification when build is failed or ready to install.

devkumar00001 commented 11 months ago

I don't think sending notifications about build status while the actual build process itself isn't guaranteed to not get killed (or at least given higher importance than other apps) while it's not in the foreground is worth implementing. It could actually make users believe the app can compile in the background, and then think compiling stopping while multi-tasking being a bug.

Then it was better earlier that it only shows notification when build is failed or ready to install.

@JavkhlanK

PranavPurwar commented 11 months ago

I don't think sending notifications about build status while the actual build process itself isn't guaranteed to not get killed (or at least given higher importance than other apps) while it's not in the foreground is worth implementing. It could actually make users believe the app can compile in the background, and then think compiling stopping while multi-tasking being a bug.

Then it was better earlier that it only shows notification when build is failed or ready to install.

@JavkhlanK

@TechnicalStudioDeveloper it just makes the whole process a waste when app gets killed

devkumar00001 commented 11 months ago

@PranavPurwar If it just show a notification when build is ready then there will no problem. A install button appear when build ready but if the app is killed then notification will not appear.And same for the failure(If compile issue occured).

devkumar00001 commented 11 months ago

@PranavPurwar If it just show a notification when build is ready then there will no problem. A install button appear when build ready but if the app is killed then notification will not appear.And same for the failure(If compile issue occured).

This commit work perfectly as I said @PranavPurwar

devkumar00001 commented 11 months ago

and what if some compile issue occurs

It says app build failed in a notification and a button appear "Show compile log" and it redirect to error activity. Till that commit all work as I said

devkumar00001 commented 11 months ago

and what if some compile issue occurs

It says app build failed in a notification and a button appear "Show compile log" and it redirect to error activity. Till that commit all work as I said

@PranavPurwar wdyt. It was not better earlier?

JavkhlanK commented 11 months ago

I don't think sending notifications about build status while the actual build process itself isn't guaranteed to not get killed (or at least given higher importance than other apps) while it's not in the foreground is worth implementing. It could actually make users believe the app can compile in the background, and then think compiling stopping while multi-tasking being a bug.

Then it was better earlier that it only shows notification when build is failed or ready to install.

@JavkhlanK

idk what you're expecting from me, did you ask a question?