search

Sketchware-Pro / Sketchware-Pro

Sketchware Pro's sources in Java. Now anyone can contribute to Sketchware Pro.
https://sketchware.pro
Other
862 stars 254 forks source link

feat: Enhanced Dependency Resolver (Speed) #942

Closed CyberXCoder-6649 closed 1 month ago

CyberXCoder-6649 commented 9 months ago

By adding caching mechanism to avoid redundant loop of resolution currently it check if already dependency downloaded or resolved, with this resolution process is now faster than before

PranavPurwar commented 8 months ago

This PR shall be closed (not merged) now.

JavkhlanK commented 8 months ago

so if I understood this right, it tries to deduplicate dependencies. why should this not be merged, @PranavPurwar?

PranavPurwar commented 8 months ago

so if I understood this right, it tries to deduplicate dependencies. why should this not be merged, @PranavPurwar?

Duplication of dependencies according to their version is already taken care of as described in a review comment

CyberXCoder-6649 commented 8 months ago

so if I understood this right, it tries to deduplicate dependencies. why should this not be merged, @PranavPurwar?

Duplication of dependencies according to their version is already taken care of as described in a review comment

Ya but it was doing that at last, i have added caching mechanism, check if library is downloaded and skip, and compare version. (while resolving) by this it improves speed

PranavPurwar commented 8 months ago

so if I understood this right, it tries to deduplicate dependencies. why should this not be merged, @PranavPurwar?

Duplication of dependencies according to their version is already taken care of as described in a review comment

Ya but it was doing that at last, i have added caching mechanism, check if library is downloaded and skip, and compare version. (while resolving) by this it improves speed

Umm resolvePOM() does it and is called much earlier than when the new sorting takes place???

CyberXCoder-6649 commented 8 months ago

so if I understood this right, it tries to deduplicate dependencies. why should this not be merged, @PranavPurwar?

Duplication of dependencies according to their version is already taken care of as described in a review comment

Ya but it was doing that at last, i have added caching mechanism, check if library is downloaded and skip, and compare version. (while resolving) by this it improves speed

Umm resolvePOM() does it and is called much earlier than when the new sorting takes place???

Could you explain? What u mean to say?

PranavPurwar commented 8 months ago

so if I understood this right, it tries to deduplicate dependencies. why should this not be merged, @PranavPurwar?

Duplication of dependencies according to their version is already taken care of as described in a review comment

Ya but it was doing that at last, i have added caching mechanism, check if library is downloaded and skip, and compare version. (while resolving) by this it improves speed

Umm resolvePOM() does it and is called much earlier than when the new sorting takes place???

Could you explain? What u mean to say?

I mean that the thing you were saying it was doing last earlier, is actually done much earlier than when your changes do (check that resolvePOM() method is called in the beginning of the method)