search

Sketchware-Pro / Sketchware-Pro

Sketchware Pro's sources in Java. Now anyone can contribute to Sketchware Pro.
https://sketchware.pro
Other
863 stars 254 forks source link

Defining AdMob app ID not enforced -> easy, hard to debug runtime crash #943

Open subhash16 opened 9 months ago

subhash16 commented 9 months ago

On latest snapshot when I build the old project make from rc05 are build successfully but app crashes

If old project uses local library then this thing happens specially.I try to redownload the library but it's also download so many library I can't tell you .but redownload not solved the problem.

IMG_20230806_192850 I download red mark toast library but it also download the yellow marks.

PranavPurwar commented 9 months ago

On latest snapshot when I build the old project make from rc05 are build successfully but app crashes

If old project uses local library then this thing happens specially.I try to redownload the library but it's also download so many library I can't tell you .but redownload not solved the problem.

IMG_20230806_192850 I download red mark toast library but it also download the yellow marks.

It is because the red library needs the yellow libraries to work. You can unselect them, but note that they may break the red library. After all, not an SWPro bug

subhash16 commented 9 months ago

But which not use library that app also crash

PranavPurwar commented 9 months ago

Send proper details about the crash. I cannot just guess the issue just by hearing "It's crashing."

subhash16 commented 9 months ago

Note:- I found why the app crash.

If I remove all admob interstitial ads and off ads then no problem when readding problem occurs

PranavPurwar commented 9 months ago

I didn't ask for SWB, but the crash log.

JavkhlanK commented 9 months ago

Note:- I found why the app crash.

If I remove all admob interstitial ads and off ads then no problem when readding problem occurs

that's why the app's crashing, you didn't define the AdMob app ID using the Component-blue setAdmobAppId Block from the View Palette

JavkhlanK commented 9 months ago

i already had this on my todo list but anyway the app shouldn't allow building projects using AdMob when the app ID isn't set.

also the way to define the app ID really should be changed from a Block to a setting

subhash16 commented 9 months ago

Where to set app I'd I in the same activity on "onCreat" or where I load or show the ads

JavkhlanK commented 9 months ago

it doesn't matter, the Block contains no code.

JavkhlanK commented 9 months ago

also @subhash16, please always tell which exact snapshot build you used, never just "latest snapshot version" since you could be out-of date.

so: e.g. "v6.4.0-SNAPSHOT-78f64546-minApi21" instead of "latest snapshot"

subhash16 commented 9 months ago

also @subhash16, please always tell which exact snapshot build you used, never just "latest snapshot version" since you could be out-of date.

so: e.g. "v6.4.0-SNAPSHOT-78f64546-minApi21" instead of "latest snapshot"

https://github.com/Sketchware-Pro/Sketchware-Pro/actions/runs/5776697634

v6.4.0-SNAPSHOT-789b95d-minApi26 I used all recent actions

subhash16 commented 9 months ago

Currently using as stable this snapshot has no problem like that. v6.4.0-SNAPSHOT-c056ca0-minApi26

JavkhlanK commented 9 months ago

I was just telling what you should start doing in the future in all bug reports, not just Sketchware Pro stuff. Exact version names help identify problems better than "latest version" since they can't be ambiguous.

subhash16 commented 9 months ago

I was just telling what you should start doing in the future in all bug reports, not just Sketchware Pro stuff. Exact version names help identify problems better than "latest version" since they can't be ambiguous.

Sir, I am really sorry for that I didn't follow the provided instructions.

subhash16 commented 9 months ago

Sorry for disturbance, Plz fix this as soon as possible

subhash16 commented 8 months ago

Hey I have an idea to fix this and it's working Open project> then goto Configuration (three dot)> AndroidMenifest> App Components> Then paste this code

<meta-data android:name="com.google.android.gms.ads.APPLICATION_ID" android:value="ca-app-pub-3940256099942544~3347511713"/>

NB:- ca-app-pub-3940256099942544~3347511713 Is your admob app ID

JavkhlanK commented 8 months ago

i already had this on my todo list but anyway the app shouldn't allow building projects using AdMob when the app ID isn't set.

also the way to define the app ID really should be changed from a Block to a setting

subhash16 commented 8 months ago

Good

subhash16 commented 8 months ago

I have an issue related to this Do that also currently I have to this manual android:name="com.google.android.gms.permission.AD_ID" Also do that when admob enable this permission also enable or give a setting

JavkhlanK commented 8 months ago

use a newer nightly build, that's already been fixed

subhash16 commented 8 months ago

IMG_20230910_215805 Oh yes I didn't notice that because I already set that manually.But there is no duplicate issue see the ss. Anyways thanks for that

subhash16 commented 7 months ago

.

subhash16 commented 7 months ago

.

JavkhlanK commented 7 months ago

why did you close all your issues…

subhash16 commented 7 months ago

Don't reopen

JavkhlanK commented 7 months ago

Enough is enough, stop spamming.