Sketchy502 / SDV-Summary

An application to display a summary of the player from a Stardew Valley save file.
206 stars 21 forks source link

Uploader 2.0: ImportError: DLL load failed (Windows) #29

Open vaindil opened 6 years ago

vaindil commented 6 years ago

Just installed the 2.0 uploader and it doesn't open, it crashes with the error below. I'm on Windows 10. Happy to help debug however I can.

capture

Laukei commented 6 years ago

If you ran the previous version, did it run okay?

On Sun, 4 Feb 2018, 18:13 Steven Hall, notifications@github.com wrote:

Just installed the 2.0 uploader and it doesn't open, it crashes with the error below. I'm on Windows 10. Happy to help debug however I can.

[image: capture] https://user-images.githubusercontent.com/771134/35780674-17644742-09ad-11e8-9416-cf4d5481d59b.PNG

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Sketchy502/SDV-Summary/issues/29, or mute the thread https://github.com/notifications/unsubscribe-auth/AD149l10NN_KGhOJPlqfWxRJX8jsOvhWks5tRfNJgaJpZM4R4qVs .

vaindil commented 6 years ago

Yes, the previous version had no issues. I installed this one over top of that, and I saw the uninstaller run as part of that.

Laukei commented 6 years ago

The curse of having no beta testers...

Could you try manually deleting the Program Files (x86)/upload.farm uploader folder and reinstalling to a completely clean directory? During dev I experienced interaction between v1 and v2 causing runtime errors, but I hadn't seen them since I added the uninstall pass to the uploader installer.

On Sun, 4 Feb 2018 at 18:19 Steven Hall notifications@github.com wrote:

Yes, the previous version had no issues. I installed this one over top of that, and I saw the uninstaller run as part of that.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Sketchy502/SDV-Summary/issues/29#issuecomment-362927398, or mute the thread https://github.com/notifications/unsubscribe-auth/AD149vH04ijEZHeT5nfN-Beesn366lJMks5tRfSTgaJpZM4R4qVs .

Laukei commented 6 years ago

Hmm, actually I'm not convinced that overwriting is the issue. I think it is probably that my machines have whatever DLL is required on their PATH because it's installed as part of my development environment, and it also existed in V1 of the uploader, but I've pruned it in V2. I'll do some more testing.

vaindil commented 6 years ago

Is this possibly the problem? I see python36.dll but no python3.dll in the install directory.

Laukei commented 6 years ago

I've zipped up the full output from freezing the application without trimming any of the unnecessary files. It's [dead link to Dropbox, "uploading to dropbox"] now. When it's done (about 10 minutes) would you mind downloading it and seeing if uploader.exe runs for you? If it does, we can be reasonably sure the issue is a DLL I've trimmed out of the bundle when preparing it - if it doesn't it suggests something isn't being included in the freezing process.

vaindil commented 6 years ago

On a whim from my previous comment, I copied lib/PyQt5/python3.dll to the root of the install location, left everything else as-is, and it worked. Looks like it's just python3.dll that's missing.

capture

Laukei commented 6 years ago

Weird, python3.dll isn't in the root directory at any previous point (neither in v1 nor the output from cx_Freeze)... how strange. Good work finding the fix though! I'll update the installer. Thanks!

vaindil commented 6 years ago

Just completely uninstalled, deleted the folder, and reinstalled, and it does work now. Thanks a ton!

jmauerhan commented 6 years ago

I uninstalled, deleted the folder, and reinstalled and it's still not working for me. The python dlls are in the folder, but I still get the error.

image

image

Laukei commented 6 years ago

Apologies, I've got a bad case of flu at the minute and it's making me more useless than normal!

If you install from the zip at https://upload.farm/static/uploader/uploader_v2.0_setup_win32.zip does the uploader start correctly?

jmauerhan commented 6 years ago

@Laukei nope, same result.

Is version 1 still available anywhere?

ETA: I hope you feel better soon!

Laukei commented 6 years ago

Changing the 2.0 to 1.0 in the URL I linked should give you the old version 1.0. The v1 installer doesn't automatically uninstall previous versions like v2 does so be sure to uninstall v2 or delete the install folder before installing v1 or I believe it causes trouble.

I'll reopen this issue when I'm up and about, might look at solving it by using pyinstaller instead of cx_freeze. Sorry v2 of the uploader hasn't worked for you! Are you happy to help me with testing future fixes?

Rob

On Mon, 5 Mar 2018, 13:46 Jessica Mauerhan, notifications@github.com wrote:

@Laukei https://github.com/laukei nope, same result.

Is version 1 still available anywhere?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Sketchy502/SDV-Summary/issues/29#issuecomment-370423030, or mute the thread https://github.com/notifications/unsubscribe-auth/AD149iKjF62TnBH2W_uNt59idIVKhBakks5tbUFtgaJpZM4R4qVs .

jmauerhan commented 6 years ago

I will definitely be happy to help in any way I can!

Laukei commented 6 years ago

Hi @jmauerhan, finally managed to get a VM running!

How do you run the uploader when you get the error? I found that if I run it by searching on the Win10 search bar for "uploader" and clicking the result then it gives an error, but the same error doesn't occur if I go to the install folder and manually run the .exe - is this the same for you?

Rob

jmauerhan commented 6 years ago

Hey, it actually started working again, without any changes on my end. I'm perplexed.

Does the uploader require some files which maybe don't get included in the actual download?

Edit: and sorry to answer your question, I use the search to type "farm" and it launches from there. That wasn't working, and now is. ¯\_(ツ)_/¯

Laukei commented 6 years ago

Hey @jmauerhan, glad to hear it fixed itself! I'm going to leave this open in case other people experience it, let me know if it comes back!

AbroadKew commented 6 years ago

I get the same error when I boot up my computer. It doesn't stop me from using the program at all though. It started happening to me after first-time installation with no overwriting.