Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
91 stars 29 forks source link

Error while unzipping due to file with a user-mapped section open. #101

Closed JLUsr closed 1 year ago

JLUsr commented 1 year ago

This issue was made with the hope to open dialogue with other users who might be having similar issues to find the cause and potentially a solution. This issue is extremely difficult for the average user to reproduce considering there is no information as to why this occurred at this time.

Describe the bug Occasionally when updating the modpack (either during PreLaunch or on an attempt to connect to the server) the client will encounter a strange error while the modpack is unzipping. The result is that the modpack does not finish transferring files to the designated folders which causes a discrepancy between the modpack.zip and the mods the client actually has.

To Reproduce Steps to reproduce the behavior: Unknown at this time. Once it occurs it happens as follows...

  1. Download modpack through AutoModpack.
  2. On the server side add or remove a mod from the modpack and restart the server.
  3. On the client side update the modpack either through PreLaunch or by attempting to connect to the server.
  4. This is where the issue might occur. Sometimes it doesn't and sometimes it does, if it doesn't happen it might occur during the next modpack update.

AutoModpack and Minecraft Version you are using (please complete the following information):

Additional context I don't know if this is actually an AutoModpack issue or if it has something to do with the source zip; however, It happens occasionally after a few modpack updates and can prevent the unzipping process from actually completing. Since the modpack size matches the server's modpack size it won't attempt to redownload/retransfer the mods to the correct directory which, in turn, causes that specific update to fail on the client side.

This is an issue I haven't had until recently, I was able to confirm that other players/clients are having the same issue. I was not able to identify why this issue occurred, how to force it to reoccur, or how to stop it. The mods being referenced change and are semi-random. I can testify that the mods themselves are not directly incompatible considering I started seeing this issue about 2 days ago and some of the referenced mods have been present for around 1 month by now.

Client & Server log See this gist.

Skidamek commented 1 year ago

Thanks for long report. However this can't happen on automodpack v3 which doesn't even contains unzipper class. It doesn't unzip anything now. That's 2.4.1 bug.

JLUsr commented 1 year ago

I should have clarified that on 3+ I am getting The requested operation cannot be performed on a file with a user-mapped section open as the error. I'll make sure to add that additional information for better clarification after generating a new log.

Skidamek commented 1 year ago

Could you also send log with this bug from 3.0.3?

JLUsr commented 1 year ago

Here is the updated gist, on 3.0.3 (from 1.19-test build, if you need it from the version of 3.0.3 that is on modrinth let me know and I'll test that too) this error only occurs when trying to join the server and does not during PreLaunch. I am also going to see if this occurs when I remove the /config/ and other folders so that only /mods/ is synced.

Edit: This is indeed still happening with only /mods/ being synced. It should be noted that all of these mods are installed on the client and are working in single-player and/or are available to see in mod menu. I also made an attempt to manually move the /mods/ folder from the server to the clients /automodpack/modpacks/my.domain.com-3037/mods/ folder to make sure there wasn't any kind of issue with files still attempting to transfer or something like that.

JLUsr commented 1 year ago

I have been able to confirm that this is a mod incompatibility issue. I am in the middle of determining what mod has caused this issue.

The cause is the mod 🗿QuiltGoSlightlyFasterLol🗿, I'll personally be making the choice to stop using it in my modpack considering it has the Cursed tag anyway. I don't know if you want to pursue this issue or not so I will leave this open, feel free to close it if you want.

Skidamek commented 1 year ago

Hm interesting, i don't know if i can do anything with that except for mark it as incompatible. Thanks for the great amount of information really appreciate that!

Skidamek commented 1 year ago

Added as breaks in 3.1.0 beta (only 1.19.2 at the moment)