Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
91 stars 29 forks source link

Relauncher won't work on either linux or windows #103

Closed MojoReach closed 1 year ago

MojoReach commented 1 year ago

Describe the bug not loading on relaunch. The issue is that the checking, downloading, and updating mods from the server are looping and the game is not reluanching. this is not an os issue it is happening with my friend

A clear and concise description of what the bug is. The bug is where when the client logs in the server says to restart but when it restarts it asks the question again

To Reproduce Steps to reproduce the behavior:

  1. connect to server
  2. download mods
  3. restart

Expected behavior A clear and concise description of what you expected to happen. I expected it to check thorugh all the mods then load minecraft but it never gets to that part

AutoModpack and Minecraft Version you are using (please complete the following information):

Additional context Add any other context about the problem here. I am using linux ubuntu 22.04 my friend is using windows 10

Client & Server log Log from ./logs/latest.log (If you scared of ip leak, please dm me logs on discord Skidam#8666) My Friend's: at net.fabricmc.loader.impl.discovery.ModDiscoverer.lambda$discoverMods$1(ModDiscoverer.java:146)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:146)
at net.fabricmc.loader.impl.FabricLoaderImpl.setup(FabricLoaderImpl.java:210)
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:187)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:148)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [10:30 PM]

at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:263)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:212)
at java.base/java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:100)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

[10:30 PM]

at java.base/java.util.zip.ZipFile$Source.findEND(ZipFile.java:1469)
at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1477)
at java.base/java.util.zip.ZipFile$Source.<init>(ZipFile.java:1315)
at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1277)
at java.base/java.util.zip.ZipFile$CleanableResource.<init>(ZipFile.java:709)
at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:243)
at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:172)
at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:186)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.computeJarFile(ModDiscoverer.java:284)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:253)
... 7 more

Mine (2023-02-24-7.log)

TheRealM18 commented 1 year ago

I have the same issue, and my workaround was add the deletedmods folder in the mods folder. This will make it launch. It seems to only happen when it has a copy of it in the main mods folder, and will not allow you to have more then one copy of it to launch. as the mod relaunches the instance into its own folder structure, it seems to be missing a guarantee Fabric-API and for me the required dependency for running it in velocity mode.

A simple fix is to allow mods that are in the default folder copied over, and have or have certain ones forced to stay.

Skidamek commented 1 year ago

Fixed in 3.1.0 beta (only 1.19.2 at the moment)