Stuck on "Install/Update modpack to join" 3.0.3-1.19.2

[ginsm]

Describe the bug

What I'm doing on the server: I'm hosting my modpack on my server with this config: automodpack-server.json.

What I'm doing on the client: I'm creating a new CurseForge instance, downloading AutoModpack, creating the client config manually (automodpack-client.json), launching the instance, connecting to the server, downloading the modpack, and restarting afterwards.

After the restart I can't seem to connect -- it simply states that it Failed to connect to the server and provides [AutoModPack] Install/Update modpack to join as a reason. There's no download button or anything of the sort showing up when I reach this screen.

It seems to think there's a modpack update, but nothing actually seems to change from what I can tell (according to the provided logs below)? I've tried restarting the client in succession and trying to connect but no luck.. and I've tried to simply connect in succession as well, but again, no luck.

Expected behavior

It should connect to the server from what I can tell.

AutoModpack and Minecraft Version

Minecraft: 1.19.2 Fabric Loader: 0.14.14 Fabric API: 0.75.1-1.19.2 AutoModpack: 3.0.3-1.19.2

Additional Context

I'm probably just misusing the mod somehow. I'm not sure if this is really a "bug" per-se and more-so just me needing help to see what I'm doing wrong. :D

Client & Server log

I can provide full logs over Discord if you'd like but for now:

Here are snippets of what's happening when I try to connect: Client, Server.

And here's an image of the screen after trying to connect: https://i.imgur.com/BbtjZ1D.png.

There wasn't anything of note in terms of initializing AutoModpack, it seems to be doing so without issue, but here's snippets of that as well: Client, Server.

[Skidamek]

I see the issue and think i fixed it in dev could you try this dev build from GitHub actions? https://github.com/Skidamek/AutoModpack/suites/11315331477/artifacts/581028054

[ginsm]

That build worked with an instance that had already downloaded the modpack but started erroring with a fresh instance that hadn't downloaded the modpack. I had installed the build on both the server and client.

With my particular setup, at least, right at the end of downloading the modpack (456-459/460) it will error out on the client with the following error (not always the same file):

[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]: java.io.FileNotFoundException: .\mods\moonlight-1.19.2-2.2.13-fabric.jar (The process cannot access the file because it is being used by another process)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.io.FileInputStream.open0(Native Method)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.io.FileInputStream.open(FileInputStream.java:216)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at fabric.pl.skidam.automodpack.utils.CustomFileUtils.getHash(CustomFileUtils.java:120)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at fabric.pl.skidam.automodpack.client.ModpackUtils.copyModpackFilesFromRunDirToModpackDir(ModpackUtils.java:212)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at fabric.pl.skidam.automodpack.client.ModpackUpdater.ModpackUpdaterMain(ModpackUpdater.java:309)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at fabric.pl.skidam.automodpack.client.ui.DangerScreen.lambda$init$1(DangerScreen.java:48)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
[02:59:46] [ForkJoinPool.commonPool-worker-1/INFO]: [STDERR]:   at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

Here's a full log: latest.log.

[Skidamek]

sus

[Skidamek]

Could you try this build please? https://github.com/Skidamek/AutoModpack/suites/11436238178/artifacts/589605810

[ginsm]

Sure! It seems to be experiencing the same issue, here's everything again:

automodpack-server.json server log client log

EDIT I tried the most recent build with Prism Launcher and it seems to be working there (4/4 tries succeeded, anyway). The current build on CF/Modrinth wasn't working with Prism before with my particular modpack either so that's progress. So I'm guessing the CurseForge launcher is being weird (hence the logs are stating the file is already in use).. I'm going to try closing the launcher as I download the pack and see if it works as expected. I'll edit this and let you know.

EDIT 2 Yeah, closing the CurseForge launcher seems to allow it to finish without issue. I'm guessing their launcher is trying to index the files or something as they're being added hence the issues? I'm not sure why no one else has ran into the issue.. maybe their modpacks finished downloading/installing before CF launcher noticed and started trying to do so?

[Skidamek]

Oh right that could be the issue

[ginsm]

On a side note, a couple things with the build you shared with me seem to not be working:

1. It'll say it's syncing when running automodpack generate with this config but when I check it doesn't actually change any of the files in automodpack/host-modpack. The server is being ran on Debian 11 (Bullseye) if that matters any. Not a huge deal since I can just move the updated files over myself anyway.
2. And, I'm not sure how this mod typically handles it, but if I delete a mod from the pack it'll still remain on the client. So, when I update a mod, the previous version ends up staying as well.

I know it's not really meant to be used as it's a dev build and still being worked on but figured I'd mention it just the same. I can share my modpack with you if you'd like (for testing purposes) or help test other builds as you work on it; just let me know & thanks for the mod -- it's pretty cool. :grin:

[Skidamek]

Ok so

1. Don't look at /automodpack/host-modpack/ look what's in the /automodpack/host-modpack/modpack-content.json

2. Thanks for remaining i am working on it, since i changed that mods are loading from default Minecraft directory many things like this need to change logic

Thank you! :)

[Skidamek]

Fixed in 3.1.0 beta (only 1.19.2 at the moment)