Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
91 stars 29 forks source link

AutoModpack mod fails to delete the outdated files/mods #111

Closed ManicQuinn closed 1 year ago

ManicQuinn commented 1 year ago

Changing an existing mod to an updated one causes the client to crash with an error after an update of the modpack, AutoModpack mod fails to delete the original file

Steps to reproduce the behavior:

  1. Stop the server
  2. Delete the outdated mod
  3. Add the updated mod
  4. Start the server to generate the new modpack
  5. Join with a client to update existing modpack
  6. You will get an error when you restart the client
  7. Inspecting the mod folder on client shows that the outdated mod is now 0KB, meaning an attempt was made to delete but it failed

Expected behavior Expected the mod to delete the outdated mod and not crash the client

Screenshots image

AutoModpack and Minecraft Version you are using (please complete the following information):

Additional context Deleting the 0KB file will fix the issue, thus confirming that AutoModpack can't seem to delete files

Client & Server log Don't think a log is needed in this instance, but if you require it, I will pm it to you

Skidamek commented 1 year ago

Yeah, yesterday i started server for my friends and they noticed that. I didn't before because somehow it works without issues on Linux. I need to fix that fast, thanks for reporting though, more motivation to do it so :)

ManicQuinn commented 1 year ago

Yeah, yesterday i started server for my friends and they noticed that. I didn't before because somehow it works without issues on Linux. I need to fix that fast, thanks for reporting though, more motivation to do it so :)

Pog, my server is on Ubuntu, but pretty sure most people I know play on Win10

Skidamek commented 1 year ago

Publishing 3.2.1 in few minutes