Doesn't put mods in mods folder

[Hexiph]

Bug description

When i join my server all the mods will be installed fine, but once i restart the game none of the mods get put into the mods folder. All my config files are imported fine and the modpack-content file saves all the mods but no mods folder is created within the automodpack folder and no mods are applied to the game.

Steps to reproduce

1. install automodpack-mc1.19.4-fabric-3.3.4
2. join modded server with automodpack
3. wait for mods to install then click quit game
4. relaunch minecraft
5. check mods folder

Expected behavior

After it says "An update has been downloaded for your modpack!" and you restart your game all the mods should be added and you should be able to join the server without issues

Actual behavior

After it says "An update has been downloaded for your modpack!" and i restart my game i try joining the server to be met with "Recieved 254 registry entries that are unknown to this client. This is usually caused by a mismatched mod set between client and server." And when looking at mods folder i find no mods except automodpack

Relevant logs

Client: latest.log Server: latest.log

Minecraft version & Mod Loader

1.19.4

Operating system

Windows 11

AutoModpack version

3.3.4

Other information

No response

Check list

• [X] I have verified that the issue persists in the latest version of the mod.
• [X] I have searched the existing issues and confirmed that this is not a duplicate.

[Skidamek]

Try this: stop the server entirely delete manually modpack-content.json from /automodpack/host-modpack/ on server and start the server again

[Hexiph]

same issue :/ i fully deleted it and restarted the server

[Skidamek]

ah alright, i think what i've typed worked, but modpack hash didn't change because of how generating logic works, could you now delete /automodpack/modpacks/ folder from client?

[Skidamek]

or just change any file/remove/add on server's modpack and regenerate it by executing /automodpack generate

[Hexiph]

ah alright, i think what i've typed worked, but modpack hash didn't change because of how generating logic works, could you now delete /automodpack/modpacks/ folder from client?

ive done this multiple times but will try to /automodpack generate

[Hexiph]

/automodpack generate didnt fix anything

[Skidamek]

alright, i pushed new commit with remove of generation optimization, in 5 minutes build should be ready to download, could you try this? There will be generated Artifacts.zip and in it, versioned folders with new mod jars https://github.com/Skidamek/AutoModpack/actions/runs/5360267423

[Hexiph]

k thanks

[Skidamek]

There it is https://github.com/Skidamek/AutoModpack/suites/13827877726/artifacts/767566458

[Hexiph]

The new jars crash the server but are loaded fine on the client

[Hexiph]

heres the log if you need it latest.log

[Shrimplonex]

The new jars crash the server but are loaded fine on the client

Try running server without the jar with "sources" in its name. Server loads fine this way for me, fabric 1.20 - However, clients still have to manually update to the manual installation of 3.3.5 in order to join which.. isnt optimal.

[Shrimplonex]

The new jars crash the server but are loaded fine on the client

Try running server without the jar with "sources" in its name. Server loads fine this way for me, fabric 1.20 - However, clients still have to manually update to the manual installation of 3.3.5 in order to join which.. isnt optimal.

and actually now realizing too, it will download/update the mods once, if you were to change something again and restart it wont. So there's still some key issue here.

[Hexiph]

The new jars crash the server but are loaded fine on the client

Try running server without the jar with "sources" in its name. Server loads fine this way for me, fabric 1.20 - However, clients still have to manually update to the manual installation of 3.3.5 in order to join which.. isnt optimal.

weird i did that and it crashed

[Hexiph]

The new jars crash the server but are loaded fine on the client

Try running server without the jar with "sources" in its name. Server loads fine this way for me, fabric 1.20 - However, clients still have to manually update to the manual installation of 3.3.5 in order to join which.. isnt optimal.

and actually now realizing too, it will download/update the mods once, if you were to change something again and restart it wont. So there's still some key issue here.

what version of fabric were you using

[Skidamek]

released 3.3.5 should fix all of this

[Skidamek]

Write message here if this doesn't work again, i will reopen the issue

[Auxioni]

It's still broken. It says that it downloads it, but nothing actually appears in the mods folder. And if you join the server after it has "downloaded" mods, it let's you right in as if they actually have been installed.

[Skidamek]

Could you send yours server's modpack-content.json? What's going on... lol You don't need to send, working on it

[Skidamek]

Hopefully finally fixed in 3.3.6

[Skidamek]

Ok now. Re-download latest jar if you have downloaded previous 3.3.6 sorry lol

[Hexiph]

I dont know if this should be put as its own issue but the same bug is occuring for the config files (it says it downloads them but they never change in game)

[Skidamek]

If you have steps to reproduce that, please make a new issue

[Hexiph]

yeah sure