Missing data in config files

[paneil]

Bug description

The client is missing a few bits of data and sometimes duplicating it in the config files which is causing errors. It seems like AutoModpack is not fully downloading the files from the modpack correctly. All the config files in the modpack is correct.

Client lambdynlights.toml content:

ight_sources.settings.entities.goodall]
                songbird = true

Modpack lambdynlights.toml content:

            [light_sources.settings.entities.goodall]
                songbird = true

Client dashloader.json content:

  "customSplashLines": [],
  "addDefaultSplashLines": true
}nna let you down", "Never gonna run around and desert you", "Never gonna make you cry", "Never gonna say goodbye", "Never gonna tell a lie and hurt you"],
  "addDefaultSplashLines": true
}dDefaultSplashLines": true
}

Modpack dashloader.json content:

"customSplashLines": ["Never gonna give you up", "Never gonna let you down", "Never gonna run around and desert you", "Never gonna make you cry", "Never gonna say goodbye", "Never gonna tell a lie and hurt you"],
  "addDefaultSplashLines": true
}

Steps to reproduce

1. Create a modpack with mod config files
2. Client downloads the modpack
3. Compare the modpack's config files and modpack's config files.

Expected behavior

The config file is a 1:1 copy

Actual behavior

The client's config file contains duplicated and missing data which is different to the modpack's config file

Relevant logs

No response

Minecraft version & Mod Loader

1.19.2 fabric

Operating system

Windows 11

AutoModpack version

3.3.8

Other information

This bug originates from 3.3.7

Check list

• [X] I have verified that the issue persists in the latest version of the mod.
• [X] I have searched the existing issues and confirmed that this is not a duplicate.

[Skidamek]

Huh this is so strange, could you send client log when you downloading whole modpack and the modpack-content.json file from server's /automodpack/host-modpack/ dir?

[paneil]

https://mclo.gs/f6ikWMs

[paneil]

modpack-content.json: https://pastebin.com/Sfnp7xNn

[paneil]

Charm is throwing out an exception due to charm.toml looking like this:

[WeatheringIron]
    #The chance of weathering increases according to the number of block faces touching water.
    "Faces increase weathering" = true
    #When more than one block face is touching water, weathering chance increases by this amount per face.
    "Face multiplier" = 0.008
    #Chance (out of 1.0) of a block being considered for weathering.
    "Weathering chance" = 0.006
    #When a block is above a bubble column, weathering chance is multiplied by this value.
    "Bubble column chance multiplier" = 4.0

[WitchesDropLuck]
    #Chance (out of 1.0) of a witch dropping a Potion of Luck when killed by the player.
    "Drop chance" = 0.05g water, weathering chance increases by this amount per face.
    "Face multiplier" = 0.008
    #Chance (out of 1.0) of a block being considered for weathering.
    "Weathering chance" = 0.006
    #When a block is above a bubble column, weathering chance is multiplied by this value.
    "Bubble column chance multiplier" = 4.0

[WitchesDropLuck]
    #Chance (out of 1.0) of a witch dropping a Potion of Luck when killed by the player.
    "Drop chance" = 0.05

but in the modpack, charm.toml looks like this:

[WeatheringIron]
    #The chance of weathering increases according to the number of block faces touching water.
    "Faces increase weathering" = true
    #When more than one block face is touching water, weathering chance increases by this amount per face.
    "Face multiplier" = 0.008
    #Chance (out of 1.0) of a block being considered for weathering.
    "Weathering chance" = 0.006
    #When a block is above a bubble column, weathering chance is multiplied by this value.
    "Bubble column chance multiplier" = 4.0

[WitchesDropLuck]
    #Chance (out of 1.0) of a witch dropping a Potion of Luck when killed by the player.
    "Drop chance" = 0.05

[Skidamek]

Could you send few examples of wrongly downloaded files and correct files?

[Skidamek]

I just can't reproduce that, everything downloads correctly

[paneil]

I'll try again and see how it goes. I found out that the config files inside /automodpack/modpacks are correct but the configs in /.minecraft/config are wrongly downloaded.

[paneil]

Only occurs when check modpack before minecraft launch. Even when there is no modpack update, it changes the content.

[paneil]

Right now, BCLib, Lamb Dynamic Lights, Dashloader and Charm's config files were affected.

[paneil]

I've got another person who is experiencing the same issue on my server

[paneil]

Even removing the modpack from the client and reinstalling it didn't work

[paneil]

Here's the whole modpack if that helps: https://file.io/ZlFKIlhhUpOe

[Skidamek]

automodpack-mc1.19.2-fabric-3.3.9-SHAPSHOT.zip Could you try this build?

[paneil]

Yes! It fixes the issue.

[Skidamek]

Great, i changed it a bit again could you try this build? automodpack-mc1.19.2-fabric-3.4.0+build.67.zip

[Skidamek]

Fixed in 3.4.0