Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.

https://modrinth.com/mod/automodpack

GNU Lesser General Public License v3.0

91 stars 29 forks source link

[1.20.1 Forge] Removing mod files are not being removed from client #146

Closed MrKashew closed 11 months ago

MrKashew commented 11 months ago

Bug description

I delete the mod from mods / moved it to a subdirectory trash folder called crashing that I use for debugging however it is still in mods folder after autoupdating

Steps to reproduce

delete mod from modpack run client autoupdate

Expected behavior

No response

Actual behavior

No response

Relevant logs

No response

Minecraft version & Mod Loader

1.20.1, Forge 47.1.43

Operating system

Windows 10

AutoModpack version

3.4.2

Other information

No response

Check list

[X] I have verified that the issue persists in the latest version of the mod.
[X] I have searched the existing issues and confirmed that this is not a duplicate.

Skidamek commented 11 months ago

Please try this build https://github.com/Skidamek/AutoModpack/actions/runs/5653297693

Skidamek commented 11 months ago

What is the bug here? Please fill the bug form!

MrKashew commented 11 months ago

Issue is removing a mod from /mods on server will not remove it from /mods on client during autoupdate

Skidamek commented 11 months ago

ok, could you try this? https://github.com/Skidamek/AutoModpack/suites/14540471950/artifacts/822817499

MrKashew commented 11 months ago

145 is soft blocking me from testing fix, will close for now and validate after / reopen if needed

MrKashew commented 11 months ago

was able to unblock myself as issue actually is caused by ATLauncher, tested on vanilla - this issue is fixed for me