Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
91 stars 29 forks source link

modpack-content.json is generated incorrectly #175

Closed zecheki closed 3 months ago

zecheki commented 9 months ago

Bug description

Some mod's modId in modpack-content.json is generated duplicatly. It seems that modpack is updated successfully when client runs its function but the problem is happened after restart. The files(whose modId is duplicated) are generated but are removed from client's mod folder when client is terminated for restart.

Steps to reproduce

  1. Start the server.
  2. Generate modpack-content.json (auto)
  3. Start the client.
  4. Connect to the server and update.
  5. Terminate the client for restart. ( After this point, files are deleted. )

Expected behavior

The modId of modpack-content.json is generated so that it does not overlap with each other. Or The files are not deleted when the client restarts.

Actual behavior

Some modId of modpack-content.json is generated so that it overlaps with each other. And The files(whose modId is duplicated) are deleted when the client restarts.

Relevant logs

No response

Minecraft & Mod Loader versions

1.20.1 forge 47.1.3

Minecraft launcher

curseforge

Operating system

Windows 11

AutoModpack version

3.5.2

Other information

No response

Check list

Skidamek commented 3 months ago

Fixed in 4.0.0 beta 1! It does not save modid's anymore as it isnt needed