Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
91 stars 29 forks source link

Mod ignores download errors #187

Closed FextraBlitz closed 3 months ago

FextraBlitz commented 8 months ago

Bug description

When a mod being downloaded encounters an error, all other mods stoop downloading, and automodpack adds the unfinished mods anyway to the mods folder and also occasionally reports that nothing went wrong.

I'm using Playit. I'm mentioning just in case it's a part of the issue

Steps to reproduce

  1. Have a bunch of mods
  2. Generate as usual
  3. Connect to server with client with automodpack (same version)
  4. Wait for results

Expected behavior

All mods actually finish downloading, or if ever one encounters an error, it should retry and NOT stop everything and NOT add those unfinished downloads to the mods folder anyways

Actual behavior

other mods dont finish downloading for some reason and bad mods get added anyways

Relevant logs

Server logs: latest.log

Client logs: latest.log

Minecraft & Mod Loader versions

Minecraft 1.20.1 Fabric 0.14.21

Minecraft launcher

Prism Launcher

Operating system

Windows 10

AutoModpack version

automodpack 3.5.2 (first observed with ver 3.4.5)

Other information

It occurs most of the time, but very rarely, it does somehow finish downloading everything

Check list

FextraBlitz commented 7 months ago

I suggest a few solutions:

  1. Attempt to redownload files that failed to download
  2. Don't replace any files in the main game folder if any file were to fail to download
Skidamek commented 3 months ago

Fixed in 4.0.0 beta 1!