Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
90 stars 29 forks source link

"/config/paxi/resourcepacks" matches "/resourcepacks/*" filter #194

Closed No3371 closed 3 months ago

No3371 commented 7 months ago

Bug description

/[04:46:24] [AutoModpackCreation-3/INFO]: File /config/paxi/resourcepacks/Translating/assets/automodpack/lang/zh_tw.json is editable! [04:46:24] [AutoModpackCreation-3/INFO] (AutoModpack) File /config/paxi/resourcepacks/Translating/assets/automodpack/lang/zh_tw.json is editable! /[04:46:24] [AutoModpackCreation-3/INFO]: File /config/paxi/resourcepacks/Translating/assets/emi/lang/zh_tw.json is editable! [04:46:24] [AutoModpackCreation-3/INFO] (AutoModpack) File /config/paxi/resourcepacks/Translating/assets/emi/lang/zh_tw.json is editable!

  "syncedFiles": [
    "/mods/",
    "/config/",
    "/resourcepacks/",
    "/scripts/"
  ],
  "excludeSyncedFiles": [
    "/mods/iDontWantThisModInModpack.jar",
    "/config/andThisConfigToo.json",
    "/mods/andAllTheseMods-*.jar",
    "/config/spark/*",
    "/config/urlmusicdiscs"
  ],
  "allowEditsInFiles": [
    "/resourcepacks/*",
    "/options.txt",
    "/config/emi.css",
    "/config/jade/*",
    "/config/chat_heads.json5",
    "/config/chatpatches.json5",
    "/config/diet-client.json5",
    "/config/iris.properties",
    "/config/lambdynlights.toml",
    "/config/pickupnotifications.toml",
    "/config/rpmtw_platform_mod.json5",
    "/config/shouldersurfing.toml",
    "/config/sodium-extra-options.json",
    "/config/sodium-options.json",
    "/config/sonance.config.json",
    "/config/stylisheffects-client.toml",
    "/config/treechop-client.toml",
    "/options.amecsapi.txt",
    "/config/sound_physics_remastered/*",
    "/config/power_config.json5",
    "/config/holdthatchunk.json"
  ],

Steps to reproduce

Make the folders and put files

Expected behavior

I don't see a reason regular path or string match would do this unless it's a contain().

Actual behavior

No response

Relevant logs

No response

Minecraft & Mod Loader versions

1.20.1 Fabric 1.14.24

Minecraft launcher

No response

Operating system

Windows 10

AutoModpack version

3.5.2

Other information

No response

Check list

No3371 commented 7 months ago

To explain the title change:

Skidamek commented 3 months ago

Fixed in 4.0.0 beta 1! Now all folders need to end with /*