AMP removes mod dependencies from client

[mimi-min]

Bug description

AMP downloads the mods, but seems to skip their dependencies for some reason, even though they are on the server, and not set to ignore in config. Edit: It seems they're getting completely removed by AMP as well.

This is what I see when I load Minecraft (after disabling some mods that work when I install them manually, but crash the client when downloaded through AMP... I'll make a different report for that though, there are many issues to sort out)

Also, after downloading and restarting, AMP and Forgified Fabric API are gone from my mod list, even though they are also present on the server.

Steps to reproduce

1. Upload mods to server
2. Attempt to connect to server with client containing only AMP and Forgified Fabric API
3. Let AMP download mods
4. Restart MC client

Expected behavior

For AMP to push the mod dependencies as well as the full mods, so the client can run.

Actual behavior

Several dependencies have not been downloaded. Edit: They also get removed after manually installing and restarting with AMP

Relevant logs

No response

Minecraft & Mod Loader versions

1.20.1, Forge 47.2.0, Forgified Fabric API 0.90.7

Minecraft launcher

No response

Operating system

Windows 11, Debian 12 with OpenJDK 21 (friend had the same issue)

AutoModpack version

3.5.2

Other information

My friend and I have been struggling getting this mod to work, so I attempted to add you on Discord (@mimi_min) but I understand if it's uncomfortable or bothersome to offer one-on-one support. Unfortunately I will likely be adding many new bug reports... so I apologize in advance.

Check list

• [X] I have verified that the issue persists in the latest version of the mod.
• [X] I have searched the existing issues and confirmed that this is not a duplicate.

[mimi-min]

I just tried setting "autoExcludeServerSideMods" to false and there is still no change, mods are being downloaded without their dependencies, and AutoModpack is disappearing from the mod list (and mods folder), which prevents me from attempting to connect to the server.

I did notice that while Forgified Fabric API also disappears from the modlist, "fabric-api-0.90.7+1.10.3+1.20.1.jar" appears in the mods folder.

I also noticed that the missing mods (aside from AMP) are appearing in the minecraft\Instances(instance)\automodpack\modpacks(world)\mods folder (client side), just not in the main mods folder, for whatever reason.

My next test was as follows:

1. Manually install each of the dependencies
2. Re-install AMP
3. Start the client again

The result: I get this pop-up, and on my other monitor I can see all of the manually installed dependencies (and AMP) disappearing from my mod list, putting me back at square one.

[mimi-min]

Currently these are the dependencies that get erased (I removed client-only mods from the server):

    Mod ID: 'ftblibrary', Requested by: 'ftbessentials', Expected range: '[2001.1.2,)', Actual version: '[MISSING]'
    Mod ID: 'architectury', Requested by: 'artifacts', Expected range: '[9.0.8,)', Actual version: '[MISSING]'
    Mod ID: 'cloth_config', Requested by: 'artifacts', Expected range: '[11.0.99,)', Actual version: '[MISSING]'
    Mod ID: 'jade', Requested by: 'jadeaddons', Expected range: '[11.5.1,)', Actual version: '[MISSING]'
    Mod ID: 'playeranimator', Requested by: 'emotecraft', Expected range: '[0.2.0,)', Actual version: '[MISSING]'
    Mod ID: 'geckolib', Requested by: 'creeperoverhaul', Expected range: '[3.1.8,)', Actual version: '[MISSING]'```

[mimi-min]

More testing, starting over again with a fresh install containing just AMP and FFAPI.

I noticed that the required dependencies do appear in the mod list for a half-second on first install, only to disappear almost immediately.

I also tried adding one of them to the synced files list in the config, with no luck, unfortunately.

[Debug-Dan]

I would like to add that I'm also having this exact same issue. I can't even get the mod to function as intended (I'm using the forge version).

For me, it seems like mainly dependencies and also a client side mod was not copied over properly. I say this because the actual transfer part of the mod (transferring the mods from the server to the client) works perfectly fine, and I know this because there is a folder inside the automodpack folder where the mod stores ALL of the downloaded files (including all the dependencies). It seems like the problem is actually transferring all the files over to the mods folder, which it fails to do and therefore makes the client crash.

Additionally I would like to add that this mod crashed upon initial install, and I noticed in the server log it kept talking about certain Fabric APIs even though I'm using the forge version. The way I even got the mod to not crash the server was to download a mod named "Forgified Fabric API".

[Skidamek]

Fixed in 4.0.0 beta 1!

[k2helix]

This keeps happening in the latest version in Fabric. I'm using Minecraft 1.20.1. I think it happens if there are chained dependencies. For instance, the mod Better Animations Collection requires the mod Puzzles Lib, which then requires ForgeConfigApiPort which automodpack does not add to the mods folder but to the AMP one.

[Skidamek]

@k2helix Thank you so much for reporting that! You can try this new dev build it should work for your case. But if threes chain of deps with 4 mods and not like 3 in your example its still not gonna work. Method handling it needs a rewrite.

[k2helix]

Thanks for your reply! I managed to solve it by just removing the second dependency from the synced files and downloading it in the client. Not ideal though. You're right, this feels like a recursion problem. Thanks for the dev build anyway!

[Skidamek]

Hopefully, it now works almost perfectly