Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
90 stars 29 forks source link

Files marked as editable still get redownloaded #233

Closed MichelJonkman closed 1 week ago

MichelJonkman commented 2 months ago

Bug description

Files that should be editable by the client get redownloaded anyways

Steps to reproduce

  1. Sync a config file
  2. Download modpack on client (and restart)
  3. Change it on the client
  4. Enter the server It will redownload the changed file

Expected behavior

No response

Actual behavior

No response

Relevant logs

No response

Minecraft & Mod Loader versions

1.20.1 NeoForge 47.2.23

Minecraft launcher

Prism Launcher

Operating system

Windows 10

AutoModpack version

4.0.0-beta1

Other information

No response

Check list

suerion commented 1 month ago

Had found a workaround for this. Because this issue is also on Fabric,

it download not the file again -> the issue happens on synchronizise from the Automodpack folder to the default config folder

here a sample for automodpack ->


"allowEditsInFiles": [
    "/options.txt",
    "/servers.dat",
    "/config/voicechat/voicechat-client.properties",
    "/config/voicechat/*",
    "/automodpack/modpacks/MYMODPACK/config/voicechat/voicechat-client.properties"
  ],