search

Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
90 stars 29 forks source link

Failed to download fabric 1.20.1 #242

Closed archenovalis closed 1 week ago

archenovalis commented 1 week ago

Bug description

Client receives modpack-content.json but cannot download any other files from the server. Client is able to download some files from modrinth.

Steps to reproduce

start server start client

Expected behavior

download files from server

Actual behavior

failed to download any mods or configs from the server

Relevant logs

[15:03:08] [AutoModpackDownload-1/INFO]: Downloading automodpack\modpacks\valowank\mods\Soaring-Structures-2-1.20.1-2.5.1-FABRIC.jar from http://192.168.56.1:29146/automodpack/9e6729aec9218c6555b3118dd8776a8bc34f1e9e
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]: java.io.FileNotFoundException: http://192.168.56.1:29146/automodpack/9e6729aec9218c6555b3118dd8776a8bc34f1e9e
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]:  at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:2015)
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]:  at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1611)
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]:  at pl.skidam.automodpack_loader_core.utils.DownloadManager.downloadFile(DownloadManager.java:168)
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]:  at pl.skidam.automodpack_loader_core.utils.DownloadManager.downloadTask(DownloadManager.java:67)
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]:  at pl.skidam.automodpack_loader_core.utils.DownloadManager.lambda$downloadNext$0(DownloadManager.java:134)
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]:  at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804)
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]:  at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]:  at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[15:03:08] [AutoModpackDownload-1/INFO]: [STDERR]:  at java.base/java.lang.Thread.run(Thread.java:842)

Minecraft & Mod Loader versions

1.20.1 fabric 0.15.11

Minecraft launcher

Prism

Operating system

win10

AutoModpack version

4.0.0beta1

Other information

file location on server is correct: image

Check list

archenovalis commented 1 week ago

hash is correct: image

archenovalis commented 1 week ago

server correctly updates client's content file and receives correct hash request: image

Skidamek commented 1 week ago

Try latest build from GitHub actions it might have been already fixed in dev

Skidamek commented 1 week ago

https://github.com/Skidamek/AutoModpack/actions/workflows/gradle.yml

Skidamek commented 1 week ago

And could you send your automodpack server config file?

archenovalis commented 1 week ago

found the issue.

server didn't generate the content.json so it had not generated the hash map. using the server to generate the content.json fixed the issue

Skidamek commented 1 week ago

Why did it not generate modpack? Was generateModpackOnStart disabled?

Skidamek commented 1 week ago

Should work now i guess, let me know if you able to reproduce it on beta 2