search

Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
103 stars 30 forks source link

[NEO/FORGE] Kotlin auto install #250

Open diskawrs opened 1 month ago

diskawrs commented 1 month ago

Bug description

Just wanted to double check since I do not see it mentioned anywhere.

As soon as Automodpack is trigger during Forge or NeoForge client launch, a copy of kotlinforforge-4.11.0-all is added to the mod folder. Is this the intended behaviour?

Thanks

Steps to reproduce

Install FOrge or NeoForge 1.20.1 Added automodpack version for either 1.20.1 Start client

Expected behavior

Should have a warning at least if this is intended behaviour.

Actual behavior

injects kotlin jar file into mod folder.

Relevant logs

No response

Minecraft & Mod Loader versions

Forge / Neoforge 1.20.1

Minecraft launcher

original launcher

Operating system

Windows 10

AutoModpack version

4.0.0-beta10-1.20.1

Other information

No mention of Kotlin on wiki, modrinth or cursed website. Include warning.

Check list

Skidamek commented 1 month ago

What? It's super strange, automodpack doesn't even use kotlin at all

Skidamek commented 1 month ago

Can't reproduce it at all, tried on both machines, windows 10, linux, nothing installs kotlin. Github repo search also doesn't show anything about kotlin, there's no way automodpack installs it...

diskawrs commented 1 month ago

Very strange... I wiped everything and it appears as soon as I use automodpack. Let me do a whole clean again. ONly mod I loaded is automodpack from Modrinth and it installs Kotlin.

Skidamek commented 1 month ago

I can't test it on original launcher tho, could you try on prism launcher? i have no other idea.. that's only thing in which my setup differs. https://prismlauncher.org/download/

diskawrs commented 1 month ago

I think I found the issue, for some reason which I cannot recall I had Kotlin on the server. It is the only mod that Automodpack will cache to the client .minecraft\automodpack folder but grabs it and installs it to the main mod folder instead of adding it to the .minecraft\automodpack\modpacks\x.x.x.x-25565-automodpack-\mods folder

Retested with Fresh install of Minecraft + different versions of 1.20.1 Neo-forge and Forge before connecting to any servers.

Skidamek commented 1 month ago

Huh, ok, could you check if it exists inside workaround.json file ~/automodpack/modpacks/<modpack> on client?

Skidamek commented 1 month ago

It is the only mod that Automodpack will cache to the client .minecraft\automodpack folder but grabs it and installs it to the main mod folder instead of adding it to the .minecraft\automodpack\modpacks\x.x.x.x-25565-automodpack-\mods folder

Do you mean it also exists inside automodpack folders right?

diskawrs commented 1 month ago

Retested again, yes it does. add it to the folder entry also is in automodpack-content.json 

  "file": "/mods/kotlinforforge-4.11.0-all.jar",
  "size": "7193768",
  "type": "other",
  "editable": false,
  "sha1": "1fd8acfd75a2be2dc3cdcc7e816482b2e427d6e5",
  "murmur": null
},
Skidamek commented 1 month ago

But is it also in workaround.json? Probably not.

If i had to guess forge copies this mod to the standard mods directory...? That kotlin mod also uses cursed injecting methods