Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
113 stars 32 forks source link

Destroy the module dependency relationship #276

Open SanQianQVQ opened 2 months ago

SanQianQVQ commented 2 months ago

Bug description

follow https://github.com/Skidamek/AutoModpack/issues/275

When AutomodPack does this, my game will directly collapse I investigated further, I found that when multiple MOD linkage involved in Fabric 1.20.1, it would strangely destroy the jar in jar dependency of MOD. As a result, the game crashes directly

This looks like a logical problem, because sometimes players will add MOD by themselves and cause this strange problem Because since Create V0.5.0E-1.19.2, Create has begun built-in Flywheel Mod no longer requires additional installation front. So Iris & Oculus Flywheel Compat should not install Flywheel, because it built-in create.

Steps to reproduce

  1. install create 0.5.1f on server and install iris, Iris & Oculus Flywheel Compat on Client
  2. connect server
  3. download files
  4. restart game
  5. gui say "restart"
  6. files 1kb
  7. game crash
  8. Iris & Oculus Flywheel Compat say lacks the front "Flywheel"

Expected behavior

The game is running normally

Actual behavior

No response

Relevant logs

No response

Minecraft & Mod Loader versions

1.20.1 Fabric 0.15.x

Minecraft launcher

Plain Craft Launcher II

Operating system

Windows11

AutoModpack version

Beta16

Other information

create 0.5.1f-build.1417 Iris & Oculus Flywheel Compat 1.1.2 iris shaders 1.7.2

Check list

Skidamek commented 2 months ago

yes, you need flywheel inside default mods folder as well. (e.g. extracted from create)

223 will fix that, then you will be able to provide mods like Iris & Oculus Flywheel Compat 1.1.2 in separate optional modpack module, which then loaded by automodpack, wont crash.

Other than that someone could implement better algorithm which could search though the modpack mods and find mod like create which provides the flywheel. As of right now, i dont have much time to do that. Current implementation