search

Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
107 stars 32 forks source link

Update loop when modpack.zip exists #58

Closed Toon2400 closed 1 year ago

Toon2400 commented 2 years ago

When updating a modpack, the zip file is 1 bit larger than the server's source, causing it to think there is an update required

Toon2400 commented 2 years ago

i believe its when any other file is updated besides the mods folder

Skidamek commented 2 years ago

Could you send client log?

Toon2400 commented 2 years ago

full log @ https://pastebin.com/A1WmRJWP

just the automodpack part right here;

[09:39:23] [main/INFO]: Prelaunching AutoModpack... [09:39:24] [main/INFO]: Checking if AutoModpack is up-to-date... preload? true [09:39:24] [main/INFO]: Didn't find any updates for AutoModpack! You are on the latest version: 2.4.0 [09:39:24] [main/INFO]: Loaded saved link to modpack: http://192.9.243.44:30037/modpack [09:39:24] [main/INFO]: Checking if modpack is up-to-date... [09:39:24] [main/INFO]: Current modpack size: 63303163 [09:39:25] [main/INFO]: Latest modpack size: 63303162 [09:39:25] [main/INFO]: Updating modpack! [09:39:26] [main/INFO]: Updating modpack [09:39:26] [main/INFO]: Downloaded 100% with average internet connection speed of 303.3 Kb/s [09:39:26] [main/INFO]: Successfully downloaded content file! [09:39:30] [main/INFO]: Successfully updated modpack!

[09:39:35] [main/INFO]: Successfully unzipped!

Skidamek commented 2 years ago

Do you know which file is that smaller one?

Toon2400 commented 2 years ago

the latest is smaller than the current downloaded by one

Skidamek commented 2 years ago

I mean which file in updated modpack.zip is smaller than this in modpack.zip on server? I can check this if you send modpack.zip from server ./AutoModpack/modpack.zip and from client ./AutoModpack/modpacks/modpack.zip

Toon2400 commented 2 years ago

it was the deletemods.txt file that had text from a prior update that i had changed on the server and that was the only thing that was changed in the modpack update

Skidamek commented 2 years ago

interesting

EmmyAllEars commented 2 years ago

I'm hitting this issue as well. delmods.txt is off by 1, and the client begins looping trying to correct it. Resolved by having the player manually download the modpack.zip from host IP and to replace modpack.zip in their /Automodpack/modpacks folder. Successful launch after that.

Skidamek commented 2 years ago

Hey, i think i fixed that issue, could you test pre-released version? https://github.com/Skidamek/AutoModpack/suites/8228379743/artifacts/359040135

EmmyAllEars commented 2 years ago

Works perfectly, thanks!!

not-Ryan commented 1 year ago

Fixed? Updated? Open? It still happens on my client (1.19.2 — v2.4.1 — MacOS). I get Successfully unzipped! and then nothing everytime I launch.

Skidamek commented 1 year ago

Hey @not-Ryan you are on time I just releasing 3.0.0 beta

Skidamek commented 1 year ago

Fixed in 3.0.0 https://github.com/Skidamek/AutoModpack/releases/tag/v3.0.0-beta