Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
98 stars 29 forks source link

Errors while downloading modpack #92

Closed dAKirby309 closed 1 year ago

dAKirby309 commented 1 year ago

Firstly is there a way to prevent the system from updating itself? Because it was working great before until it updated itself to the new version (3.0.1) and then things broke.

I'm on Minecraft 1.19.0 Fabric. The Automodpack jar version I had (v2.4.1) on my client and server is no longer recognized as a mod, and this newest 3.0.1 version that it installed or even when I installed it manually makes the mod "seen" in my list of mods on client, but none of its functionality works. No check for update button, no auto-syncing with our server, nothing.

And also no mention of Automodpack doing anything in the server logs.

I don't know why or how it got messed up but this is a setback since I was needing to test other things and instead I had to spend my time trying to figure this out to no avail.

I tried updating and messing with Automodpack on my server and client. No dice.

Skidamek commented 1 year ago

Oh u right, mod didn't build correctly lol Now that is link from github actions this build should be correct https://github.com/Skidamek/AutoModpack/suites/10811957751/artifacts/543984796

dAKirby309 commented 1 year ago

When trying that new build you sent (named artificats.zip), I got a critical error when trying to download the modpack. It seems to have stopped at the first mod in the list (alphabetical order), animal-feeding-trough. image Client log: latest.log

Skidamek commented 1 year ago

Hmm well that's ok i think for now 3.0.3 is good enough if someone doesn't have some files which shouldn't even be in modpack... Thank you so much! I will fix it next time probably with 3.0.4 release! :) Have a good one!

Skidamek commented 1 year ago

Oh and button is below the error message progress XD

dAKirby309 commented 1 year ago

Ok, I'll let you know if I encounter more issues. Seems like that first 3.0.3 you sent out is good, but I had a niche concern but it seems to be working like it should for now so I won't bring it up unless I can prove it's a problem. Thanks for your work on this! It's an extremely useful mod you've made! <3

AStrong34 commented 1 year ago

@Skidamek Are you able to revert everything and go back to the last working version (v2.4.1) and test the new update for offline use on your end so we can continue using this cool mod until the update is ready without issues?

Sorry for that. You can use 2.4.1(.0) but it have even more bugs. Releasing 3.0.3 in few mins should be ok

So does version 2.4.1 work again? I know when you first made changes to not have it auto update when using 2.4.1 it would not work correctly. Currently having a ton of issue trying to get version 3.0.3 to work and would like if you just reverted every single update and go back to that last known working version (v2.4.1) and to not update this mod anymore as there were no issues we encountered when using it and did everything correctly! Thank you!

dAKirby309 commented 1 year ago

I know that personally, I would prefer being able to use 2.4.1 instead of 3.0.x until version 3 is polished and extensively tested, since 2.4.1 never gave me any trouble and now I'm not able to use it anymore.

I know I said that 3.0.3 was working for me, but I know someone that it is not working for (using the same mod pack) and they're having issues with it. And after some more testing, it seems I may also be having an issue with it, where it doesn't seem to work potentially with .minecraft folders that are in another location, and are in %appdata% via a symbolic link. When I tried my Minecraft folder that was a symbolic link, the game didn't want to launch after downloading the modpack from the server.

I know you mentioned that you say 2.4.1 has several bugs. Though my friend and I haven't encountered a single issue with it in all the time we used it, except there were a couple times where we had to manually replace our modpack.zip on our client with the one from the server.

Is there any way that this 3.0.3 mod can be considered a beta? I think this mod is great and super useful, but I just don't feel it is polished and ready enough to be the version everyone has to use, before it gets polished.

OR is there something I can do on my end to allow 2.4.1 to work as intended?

oakelope commented 1 year ago

If you look threw the thread there is this version that works mostly just make sure to disable the update modpack button in the config because I forgot to disable that from updating the mod

https://github.com/Skidamek/AutoModpack/issues/92#issuecomment-1415115112

dAKirby309 commented 1 year ago

If you look threw the thread there is this version that works mostly just make sure to disable the update modpack button in the config because I forgot to disable that from updating the mod

#92 (comment)

@oakelope Here's the issue with that, I cannot connect to the server anymore with 2.4.1 so far, any time I've tried. image And I also get this sort of error image

I've not been able to figure that out. It didn't happened back before 2.4.1 received a disabled auto update change made to it.

Client log from attempting to use the custom 2.4.1 build. latest.log

I also tried the one made by @RatDonkeyGoat and it gives the same error(s).

2.4.1 now works so perfectly until the point where you can actually join the server.

dAKirby309 commented 1 year ago

I have realized that the Connection Lost error that I am now getting on 2.4.1 (without auto update) must be due to some mod-related issue on my end (that is what I had already half-assumed but I wasn't sure). I tried testing 2.4.1 with a small number of mods instead of all of our mods, and it works. So I'll try spending time tomorrow troubleshooting that.

It's strange though why 2.4.1 was working with our mods before, but now it isn't. So I'll have to figure out what is causing the issue.

Skidamek commented 1 year ago

@Skidamek Are you able to revert everything and go back to the last working version (v2.4.1) and test the new update for offline use on your end so we can continue using this cool mod until the update is ready without issues?

Sorry for that. You can use 2.4.1(.0) but it have even more bugs. Releasing 3.0.3 in few mins should be ok

So does version 2.4.1 work again? I know when you first made changes to not have it auto update when using 2.4.1 it would not work correctly. Currently having a ton of issue trying to get version 3.0.3 to work and would like if you just reverted every single update and go back to that last known working version (v2.4.1) and to not update this mod anymore as there were no issues we encountered when using it and did everything correctly! Thank you!

So strange that you didn't have any bugs i thought everyone having many troubles because of number of known issues, so with this knowledge someone for sure doesn't have also any trouble with 3.0.3 because nobody comes here to say that everything is working...

But yes you can without problem download 2.4.1.0 version from modrinth it works the same as previous 2.4.1 but it is without auto updating. However if you could describe your problem that's would be win-win right?

Killasaurus-Warbear commented 1 year ago

I'm having the auto-restart loop issue with 3.0.3. Not sure if I should start a new issue or not, but I haven't been able to make any progress resolving it. Any new information?

Skidamek commented 1 year ago

I'm having the auto-restart loop issue with 3.0.3. Not sure if I should start a new issue or not, but I haven't been able to make any progress resolving it. Any new information?

Start new issue and send there two latest logs from client please

Skidamek commented 1 year ago

Ok guys i was thinking about that and i made a decision to remove relauncher and copy mods to main minecraft folder kinda like it was before what do you think about that? This segregation to folders and auto relauncher is cool but due to many issues you having i think would be better to change that, no?

dAKirby309 commented 1 year ago

Is that is the main cause of the issues that people are having, then that may be for the best. I like the ideas that you have made it happen for version 3+, But I have found the older versions to be a lot more reliable. I was able to get version 2.4.1 working, and I found the culprit. It was another mod that wasn’t properly supported by 1.19 Fabric.

But I do like some of the changes in version 3+ such as auto restarting the game. It didn't work often, but I did get it to work a couple times which was nice.

Also with 2.4.1 there seems to be a somewhat frequent issue whenever making a change to the modpack on the server side, clients that synchronize their midpack often causes the automodpack loading screen to freeze, and then we have to forcibly close the game and then delete the existing automodpack folder and let it generate a whole new one to fix it

Eianex commented 1 year ago
  1. Hi @Skidamek, I appreciate your active involvement with the community. I'm encountering the same issue as the original poster with the error message:
"Uncaught exception in thread "main"
java.lang.RuntimeException: Error creating Mixin config nochatreports.mixins.json for mod nochatreports
at net.fabricmc.loader.impl.launch.FabricMixinBootstrap.init(FabricMixinBootstrap.java:95)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:153)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: org.spongepowered.asm.launch.MixinInitialisationError: Error initialising mixin config nochatreports.mixins.json
at org.spongepowered.asm.mixin.transformer.Config.create(Config.java:153)
at org.spongepowered.asm.mixin.Mixins.createConfiguration(Mixins.java:100)
at org.spongepowered.asm.mixin.Mixins.addConfiguration(Mixins.java:87)
at net.fabricmc.loader.impl.launch.FabricMixinBootstrap.init(FabricMixinBootstrap.java:93)
... 3 more
Caused by: java.lang.IllegalArgumentException: The specified resource 'nochatreports.mixins.json' was invalid or could not be read
at org.spongepowered.asm.mixin.transformer.MixinConfig.create(MixinConfig.java:1290)
at org.spongepowered.asm.mixin.transformer.Config.create(Config.java:148)
... 6 more"

I am using version 3.0.3 of the Automodpack. Previously, I was using version 2.4.1, and it worked without any issues. I love the new progress bar animation during downloads, but I have been facing several errors, and it has been challenging for me as a server admin. I would like to have the simplicity of the previous version along with the beauty of the current version of this mod.

  1. I am also experiencing this error message:
Incompatible mod set!
net.fabricmc.loader.impl.FormattedException: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed!
    at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:192)
    at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:148)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed!
    at net.fabricmc.loader.impl.discovery.ModDiscoverer.lambda$discoverMods$1(ModDiscoverer.java:146)
    at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
    at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:146)
    at net.fabricmc.loader.impl.FabricLoaderImpl.setup(FabricLoaderImpl.java:210)
    at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:187)
    ... 3 more
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Error analyzing [C:\Users\atama\AppData\Roaming\.minecraft\automodpack\modpacks\91.134.125.156-8045\mods\fabric-api-0.63.0+1.19.2.jar]: java.util.zip.ZipException: zip END header not found
    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
    at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
    at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:562)
    at java.base/java.util.concurrent.ForkJoinTask.reportExecutionException(ForkJoinTask.java:604)
    at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:981)
    at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:143)
    ... 5 more
Caused by: java.lang.RuntimeException: Error analyzing [C:\Users\atama\AppData\Roaming\.minecraft\automodpack\modpacks\91.134.125.156-8045\mods\fabric-api-0.63.0+1.19.2.jar]: java.util.zip.ZipException: zip END header not found
    at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:263)
    at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:212)
    at java.base/java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:100)
    at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
    at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
    at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
    at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
    at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: java.util.zip.ZipException: zip END header not found
    at java.base/java.util.zip.ZipFile$Source.findEND(ZipFile.java:1469)
    at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1477)
    at java.base/java.util.zip.ZipFile$Source.<init>(ZipFile.java:1315)
    at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1277)
    at java.base/java.util.zip.ZipFile$CleanableResource.<init>(ZipFile.java:709)
    at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:243)
    at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:172)
    at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:186)
    at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.computeJarFile(ModDiscoverer.java:284)
    at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:253)
    ... 7 more
Eianex commented 1 year ago

Postdata:

  1. I was using 3 mods:

and it did autoinstalled me this one:

  1. I loved the possibility as a server admin to being able to separate client-side mods and server-sided ones. Thanks for all!
Skidamek commented 1 year ago

Thanks, working on it, at the moment you can still use old 2.4.1.0 (updated from e.g. modrinth) if that was not a problem

Skidamek commented 1 year ago

Fixed in 3.1.0 beta (only 1.19.2 at the moment)