search

Skidamek / AutoModpack

Enjoy a seamless modpack installation process and effortless updates with a user-friendly solution that simplifies management, making your gaming experience a breeze.
https://modrinth.com/mod/automodpack
GNU Lesser General Public License v3.0
91 stars 29 forks source link

AutoModPack copying some mods as type "other" #99

Closed technobaboo closed 1 year ago

technobaboo commented 1 year ago

Describe the bug I looked a bit at the code and it seems that some of my mods in the server mods folder do not have the type "mod" so they are copied straight to the .minecraft/mods folder, causing many cascading issues such as all of those mods failing the hash or exists check causing them to try to be updated causing a whole startup loop.

To Reproduce Steps to reproduce the behavior:

  1. Have a quilt server with mods such as Jade, Trinkets, Amethyst Gravity, etc. that don't appear as a mod
  2. Download modpack from client
  3. Restart, restart again, and again, forever

Expected behavior Any jar in the mods folder ideally should be treated as a mod

Screenshots If applicable, add screenshots to help explain your problem.

AutoModpack and Minecraft Version you are using (please complete the following information): AutoModPack v3.0.3 and Minecraft 1.19.2

Additional context modpack-content.zip Contains the JSON that has a bunch of mods labeled as "other"

Client & Server log Server: latest.log.zip Client: https://mclo.gs/VVFAUSB

technobaboo commented 1 year ago

aha, I think this is it: https://github.com/Skidamek/AutoModpack/blob/92f2d3cebe2577a0789030a58fc9d5706edf7b14/common/src/main/java/pl/skidam/automodpack/modpack/Modpack.java#L174

Skidamek commented 1 year ago

well yes you right but why it returns null from modid in first place....

technobaboo commented 1 year ago

I'm still not sure tbh, i know that it worked properly by manually setting all the mods in the json to the right type...

On Sun, Feb 12, 2023 at 9:31 AM Skidam @.***> wrote:

well yes you right but why it returns null from modid in first place....

— Reply to this email directly, view it on GitHub https://github.com/Skidamek/AutoModpack/issues/99#issuecomment-1426984641, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCU4EHU6KCAMS6N5CNEOL3WXCUVPANCNFSM6AAAAAAUZFFSNA . You are receiving this because you authored the thread.Message ID: @.***>

TheDeusDeceptor commented 1 year ago

Happened to me, after changing type to mod client wont load them at all...

Skidamek commented 1 year ago

Happened to me, after changing type to mod client wont load them at all...

Are you using 1.19.2, 1.19.1 or 1.19(.0)?

TheDeusDeceptor commented 1 year ago

Happened to me, after changing type to mod client wont load them at all...

Are you using 1.19.2, 1.19.1 or 1.19(.0)?

1.19.2

Skidamek commented 1 year ago

Happened to me, after changing type to mod client wont load them at all...

Are you using 1.19.2, 1.19.1 or 1.19(.0)?

1.19.2

Great, this should be fixed already. So if you want to try it, get new not yet released build it from github actions https://github.com/Skidamek/AutoModpack/suites/12093344356/artifacts/636825454

TheDeusDeceptor commented 1 year ago

Happened to me, after changing type to mod client wont load them at all...

Are you using 1.19.2, 1.19.1 or 1.19(.0)?

1.19.2

Great, this should be fixed already. So if you want to try it, get new not yet released build it from github actions https://github.com/Skidamek/AutoModpack/suites/12093344356/artifacts/636825454

sorry for disturbing, I had few Forge mods which caused issues, my apologies (3.0.3 works great with other 100+ mods I have) anyway, would be nice to have sort of check function if there are forge mods in future, just in case thanks for help!

Skidamek commented 1 year ago

not really necessary in future with changes i made

Skidamek commented 1 year ago

Fixed in 3.1.0 beta (only 1.19.2 at the moment)