SkidderMC / FDPClient

Minecraft 1.8.9 forge hacked client forked from LiquidBounce
https://fdpinfo.github.io/
GNU General Public License v3.0
368 stars 172 forks source link

Jump but motion is wrong #697

Closed siuank closed 1 year ago

siuank commented 1 year ago

in Criticals - MotionCriticals - jump

"jump" -> mc.thePlayer.motionY = 0.42

but it can be detected by the following code in the server:

double motionY = moveEvent.getTo.getY() - moveEvent.getFrom().getY();
double different = motionY - 0.42;
if (Math.abs(different) < 1.7E-14) {
    fail("Jump with wrong motion");
}

because the correct motion should be 0.42F (float instead of double) but the best way is mc.thePlayer.jump(), instead of mc.thePlayer.motionY() = 0.42f.toDouble()

siuank commented 1 year ago

the same problems in many modules, such as Speed Velocity and so on

ghost commented 1 year ago

Best Client BIG W!

ghost commented 1 year ago

also i completely agree making the player jump instead of just changing motionY (for a jump) is far better

renshengongji commented 1 year ago

正确的,不理解fdp为什么不直接jump还要motionY如果有jumpboost直接去世并且vulcan好像能检测

siuank commented 1 year ago

正确的,不理解fdp为什么不直接jump还要motionY如果有jumpboost直接去世并且vulcan好像能检测

算是LiquidBounce的问题吧 FDP直接用下来就没动过了

MatrixAura commented 1 year ago

It's fixed on JumpVelocity

renshengongji commented 1 year ago

It's fixed on JumpVelocity

fdp不是早修复了吗,现在有jump和Motion