SkillDevs / electric_dart

A Dart implementation for Electric (electric-sql.com).
Apache License 2.0
104 stars 9 forks source link

Pass $workingDirectory as source to cli volume as it breaks docker run on macos #11

Closed davidhole closed 8 months ago

davidhole commented 8 months ago

Passing the current directory (.) as a docker volume brings up an error on macos. As the working directory is set in the Process.run call, passing it through again in the docker run command has the same effect but works on mac os.

Screenshot 2024-03-05 at 12 51 01 pm
davidmartos96 commented 8 months ago

Thank you! That's interesting, as it has worked correctly on my tests on Linux and Windows with the latest Docker version.

What version of Docker are you using?

I don't mind using the full path if it improves compatibility with other Docker versions.

davidhole commented 8 months ago

You're right, looks like I was using an old version installed through Homebrew and not the client from Docker Desktop, working well after an update :)

davidmartos96 commented 8 months ago

Do you know the version you were using? Depending how old it was it might be worth adding the full path. As you said, it should be the same behavior.

davidhole commented 8 months ago

@davidmartos96 It was quite old, version 20. I think it's probably safe to leave as is :)