search

SkinsRestorer / SkinSystem

The Minecraft SkinSystem for SkinsRestorer
MIT License
131 stars 47 forks source link

[Bug] Invalid login details kill php-fpm #119

Open Shark-vil opened 2 years ago

Shark-vil commented 2 years ago

Past issue: https://github.com/riflowth/skinsystem/issues/118

When you try to access a non-existent host, the site kills the "php-fpm" process.

chrome_eLPJgFFGdB

The decision to shove the block into the "try catch" does not help. It seems to me it is worth removing the invalid host from the code. Perhaps there are problems on the Mujang servers, and this is temporary, but it seems to me that they no longer use this address.

https://github.com/riflowth/skinsystem/blob/5103b54d62ce2c68647a14e907df15aaa7ac1334/resources/server/libraries.php#L49-L59

Shark-vil commented 2 years ago

You can consider an alternative solution, if the second site goes offline, it will not need to be removed. https://github.com/riflowth/skinsystem/pull/120

Shark-vil commented 2 years ago

The timeout will prevent curl from freezing while waiting, and "$skip_skinstatus_links" is needed to avoid an eternal loop.

Shark-vil commented 2 years ago

Update. I still commented out this block. Because even though "php-fpm" no longer hangs, the presence of an invalid link gives an incorrect error message. If a person has entered an incorrect login, he will be given an error about a bad "url", which is not very logical. I would suggest revising your error output logic if possible. What are these calls to third-party sites for? https://github.com/riflowth/skinsystem/pull/120/commits/fe7d33d5525f63d9d2a44730dcf14226fd60a785