search

SkipLabs / skip

Skip is a framework for building reactive services
https://skiplabs.io
MIT License
152 stars 10 forks source link

Remove System.read_line and SKIP_read_line #410

Open jberdine opened 2 weeks ago

jberdine commented 2 weeks ago

Convert remaining uses of System.read_line to IO.BufferedReader, and remove System.read_line and associated runtime system functions SKIP_read_line, SKIP_read_to_end and their support code.

Originally posted by @jberdine in https://github.com/SkipLabs/skip/issues/409#issuecomment-2407302847

jberdine commented 1 week ago

Note that skjson calls read_line from a closure passed to Context.runWithGc. So since IO.BufferedReader is mutable, it cannot be used there, and some redesign will be needed.

The use in skdb appears to require a mutable global, so also will need some redesign.