SkipLabs / skip

Skip is a framework for building reactive services
https://skiplabs.io
MIT License
152 stars 10 forks source link

Revise import url handling #427

Open jberdine opened 3 days ago

jberdine commented 3 days ago
          It's because for vite we use the `await import ` pattern that returns a module with a default property that contains the URL in string format.

It's was a fix made in a bad place to manage that. The import for Url pattern shall be correctly manage each time it's used. In skipruntime_init.ts it's badly managed the wasmURL function shall returns a Promise<URL | string> and the the default property as string of await import("./libskip-runtime-ts.wasm?url") that should be returned and not the await directly.

_Originally posted by @skiplabsdaniel in https://github.com/SkipLabs/skip/pull/421#discussion_r1810026244_