search

SkippTekk / Biscuits-Industrial-EJS

The open source for the dev of Biscuits Industrial, an Eve online fan based custom website.
https://skipptekk.com
0 stars 2 forks source link

Move mailserver to environment variable #1

Open alpuks opened 2 years ago

alpuks commented 2 years ago

In https://github.com/SkippTekk/Biscuits-Industrial-EJS/blob/master/server/mail.js you have your mailserver hardcoded.

I think it's better to move it to an environment variable, so if someone wants to use your project as-is, they wouldnt need to manually change the code :)

Should be a rather trivial fix

SkippTekk commented 2 years ago

That is in the works for the future! I'm just currently working on a few other things atm and normally i don't expect people to use this. It's currently to my own settings and server. Some people were bickering to me about wanting to see the hard code of the website so they know it's trusted and such for the future use of this project.

alpuks commented 2 years ago

That's good to know!

I might contribute something at some point, since I'm working on making something similar for my own use

SkippTekk commented 1 year ago

Hi there, just to let you know this code will be archived as i have changed it to React and NODEJS for the backend. BUT we will have this in the future of the new code :)