search

Skippeh / calcrust.com-frontend

The frontend for calcrust.com.
GNU General Public License v3.0
6 stars 4 forks source link

Merge recipe and item list on items page #11

Closed bighuggies closed 8 years ago

bighuggies commented 8 years ago

Fixes #5

The new page: wvv6cok

I realised that it makes sense to merge the two lists before implementing categories. The code for the item page is much simpler now so categories will be very quick to implement.

I'm not sure about the link I added to the item, it adds a lot of clutter. A solution would be to merge the recipe/blueprint page and the info page for an item (since they are mostly the same), meaning we could remove the recipe link altogether.

I also used the beaker icon to indicate bp/recipe rather than the page icon which is being used on the item page, I think it conveys more meaning even though it isn't consistent.

Hyllesen commented 8 years ago

Personally I like the beaker icon. Excited to see how performance is with only one list compared to 2.

Skippeh commented 8 years ago

That beaker icon is a lot better than the page icon. Could use it instead of the page icon all together.

Don't know about you guys, but the "Recipe" text feels redundant. Could move it to a tooltip?

Also, was it intentional to remove the requirements under recipes?

Gonna merge this and see if i can improve some things.

bighuggies commented 8 years ago

It doesn't perform much better unfortunately. I think perfect-scrollbar is causing most of the jank, removing it drops the render time from ~600ms to ~300 on my machine.

@Skippeh It wasn't intentional, I think they should be put back. It's important information to have at a glance.

bighuggies commented 8 years ago

I initially had the icon just by itself. The issue with that is then the icon becomes very easy to miss - I can see users not noticing it and wondering where the recipes are.

Hyllesen commented 8 years ago

Maybe make the icon a itty bit bigger, I agree the recipe text is a bit redundant.

Skippeh commented 8 years ago

What do you think of the current behaviour?

Edit: Replaced item descs with recipe requirements and moved item desc to tooltip. Seems fine to me.