Skittyblock / aidoku-community-sources

Public sources for the Aidoku application
Apache License 2.0
444 stars 158 forks source link

Update to the new Url for ComicK #534

Closed HeapUnderfl0w closed 11 months ago

HeapUnderfl0w commented 11 months ago

Checklist:

ComicK moved from their .app domain to https://comick.cc (and https://api.comick.fun for the API).

Was unable to test the source, as the aidoku-cli just segfaults on my machine. Should not cause any issues tho, as this is purely a url change in the strings.

Fixes #533

Skittyblock commented 11 months ago

aidoku-cli just segfaults on my machine

you need to download aidoku-cli from the repo. I'm guessing you're using the version on brew, which doesn't work.

also that doesn't prevent you from testing; you can just compile the .aix and then install it on your device.

HeapUnderfl0w commented 11 months ago

Ah right, didnt know that you could install .aix standalone, will do that next time.

HeapUnderfl0w commented 11 months ago

The API docs of ComicK mention specifically to use https://api.comick.fun as the api root.

The .cc will work fine i guess, just feel like i should at least mention it: image https://api.comick.fun/docs/static/index.html

Skittyblock commented 11 months ago

I think it means you have to use api.comick.cc and not comick.cc -- likely a typo/outdated. I'm guessing that the .fun domain will likely stop working at some point since they've migrated from it, so the .cc domain is a better choice for now.