Skittyblock / aidoku-community-sources

Public sources for the Aidoku application
Apache License 2.0
418 stars 144 forks source link

feat: add libgroup template and mangalib source #634

Closed vlapsk1y closed 4 months ago

vlapsk1y commented 5 months ago

Checklist:

I know about this pq (#176), but it's not merged into main branch and soon stay deprecated, because mangalib.me in the near future get very major update (test-front.mangalib.me). The new version of mangalib has become unparseable and open at browser as web app.

vlapsk1y commented 5 months ago

as for "site id", I wanted to make the task easier for those who want to implement other sites of libgroup. Although them still need to edit template, cuz nsfw sites has own cdn. I really didn't knew about that fact, until checked before writing the comment.

Skittyblock commented 5 months ago

yes but the point of the template is to contain all things specific to the template that the individual websites use, but then it's the job of the actual sources to just use the template while providing the source specific things. for example, the individual source should be able to give any base url to the template, and the template shouldn't need to know which exact source it is.

vlapsk1y commented 5 months ago

I understood your point, I'll make a commit in the next days. thanks u.

Skittyblock commented 5 months ago

icon should be 128x128 and make sure to fix the warnings clippy generates when running cargo +nightly clippy, but after that it should be good