Skittyblock / aidoku-community-sources

Public sources for the Aidoku application
Apache License 2.0
444 stars 158 forks source link

fix(mangademon): rewrite most of the source to account for a site remake #756

Open AlokSwaminathan opened 2 months ago

AlokSwaminathan commented 2 months ago

Checklist:

Closes #753

AlokSwaminathan commented 1 month ago

seeing a crash when opening martial peak due to duplicate chapter identifiers. double check how you're assigning chapter ids and make sure they're unique, and make sure to test on device

I've been reading from mangademon with this version of the source for a few weeks, I have 60 from it and I haven't noticed any issues. What chapter on martial peak are you having problems with, I tested a few chapters on there and they seem to work for me.

Skittyblock commented 1 month ago

interestingly enough, it's only happening when run on the simulator. none of the images load for me on device though. the culprit for martial peak is /chaptered.php?manga=1&chapter=3705, which I can see on the site is listed twice. this is their mistake, but you should probably filter out duplicates on our end within the source

AlokSwaminathan commented 6 days ago

I took a look at 3705 and it seems to work on my phone even though there were chapters with that number. I just went ahead and removed duplicates anyway though