Skittyblock / aidoku-community-sources

Public sources for the Aidoku application
Apache License 2.0
444 stars 158 forks source link

fix(manhuagui): incorrect chapter order #785

Closed dyphire closed 1 week ago

dyphire commented 3 weeks ago

Checklist:

dyphire commented 3 weeks ago

does this really change the chapter ordering? you're reversing the way you parse all the elements, but then you reverse the whole chapter list again, so doesn't it end up being the same? do you have an example manga that has incorrect ordering with the old version but is fixed with this version?

This is not true, it is done because of the special structure of the chapter list in this web page, which was overlooked by the previous people who implemented this source. It can be confirmed by checking the web page on PC: https://www.manhuagui.com/comic/28004/

image

image

manhuagui v2: IMG_4931 This PR: IMG_4933 IMG_4932

dyphire commented 3 weeks ago

Any more problems here?