Skjutsgruppen / skjutsgruppen-reactnative

React native app for Skjutsgruppen http://www.skjutsgruppen.nu/
MIT License
22 stars 7 forks source link

miscellaneous query #205

Closed samitalalchan closed 6 years ago

samitalalchan commented 6 years ago

@MattiasJay We have few query in our way to development... We want to be clear about few things before we start some new functionality and new design

  1. Overall process of admin of group. Does he/she has to be participants of the group? How many admins can be there? Once owner assign other user as admin can he revoke the permission? Can an admin(not owner) add another admin?

  2. Overall flow of report (ride/comment/user/experience)

  3. According to new design of add rides, while adding rides with return rides... there is no design for adding return rides.

  4. How should we list the active rides? In order of created date or ride dates

  5. Conventions for photo file names - The file names that has been stored with the legacy/old data, does not match with the photographs of users provided. There seems to be certain conventions that has been used which we do not know about.

MattiasJay commented 6 years ago

I see that we have covered 1-3 in other issues.

  1. List as ride dates (the closest in time on top)

  2. This is beyond my knowledge. What is an convention? You have to fill me in more or this, or maybe push this to a Skype meeting so you can explain more @anjhero @anjesh .

samitalalchan commented 6 years ago

@MattiasJay Few more random queries

  1. While adding user from contact as the participants in the group, what will happen. 1a. Are we sending sms to them for every notification (Someone shares trip in the group, Someone shares location and so on.)
  2. When we offer a ride inside asked for ride from the comment section, shall we create feed for that ride in the main ride feed too. Or that ride will be created for the that particular ride only.
  3. When a group has no enablers and the No enablers screen is shown to the participants, What will happen when a non participants visits the group page. 3a. Will he see the normal Join group screen or the same no enablers screen. 3b. Can he directly click I an do it and become an enablers ( that will be considered that he joined the group as well)
MattiasJay commented 6 years ago
  1. IF adding participant from contact THIS will happen:

    • IF this participant joins the movement (creates an account) THEN she will be automatically added to the group
    • But no nothing more; they will not get any notifications if they haven't joined (notifications are only in-app for verified participants)
  2. Yes; create for feed. It is to be treated as any normally created ride.

  3. a: he will se the normal join group page. and yes 3 b: after he wants to participate he will see the "no enabler" and can become an enabler himself. The only exeption from this is closed groups; then only people in the group can become new enablers.

samitalalchan commented 6 years ago

@MattiasJay 3 b: The only exception from this is closed groups; then only people in the group can become new enablers.

So does this means when a non participants clicks on the closed group (No enablers), the following will happen

MattiasJay commented 6 years ago

Correct @samitalalchan ! 👍

Which reminds me, we should put these pending requests somewhere...

samitalalchan commented 6 years ago

@MattiasJay

  1. When a user clicks on the bundle message related to ride/group, what should be the message on the top message inside the respective ride/group. If the bundle message reads Mattias + 5 Kathmandu - Pokhara

  2. While adding ride do we need to put limit on time. Like for example now you can add ride from today to the infinite time. Even if we can add ride for today, i guess there should be some time between the time you and the ride and the ride time.

  3. Have we decided on how to show flexible time in the feed card ???

MattiasJay commented 6 years ago
  1. Inside the rides/groups the feed will follow time entry logic (time of comment/post)

  2. Sorry, could you rephrase this one and maybe show me where this problem occurs when adding a ride? 😺 , I didn't get it, but maybe that's because it's late Friday ;-)

  3. Yes, it will be shown like the design is on the first card in the feed on inVision: https://projects.invisionapp.com/d/#/console/12489615/262118123/preview

samitalalchan commented 6 years ago

@MattiasJay

  1. I guess you didn't reply to my query 1 that is When a user clicks on the bundle message related to ride/group, what should be the message on the top message inside the respective ride/group. If the bundle message reads Mattias + 5 Kathmandu - Pokhara
  2. About adding time, I will give you a scenario so that you can understand it clearly. I will first describe what happens in our app. Lets suppose its 20th Feb 9 AM. If i go to add screen and click on the offer/ask for a ride and reach the date/ time screen, I will be able to add a ride starting from 20th Feb 1 AM which should not be valid Isnt it??? 2a. So what i want to suggest is lets disable the time before 9 AM. 2b. Or, How about while adding ride, the time between adding rides and actual ride should be n hours or at least 1 day ( you can suggest the n hrs or day). This is not an issue,It is just my suggestion :)
  3. About Delete functionality in Group. Can the user/admin delete comments only or they can delete shared or offered comment as well as marked in the figure below.

delete

MattiasJay commented 6 years ago

Hi!

  1. I think we're misunderstanding each other here on issue number one :-) . Can you clarify what you mean with "top message"? I thought you were refering to the feed and that's why I wrote

Inside the rides/groups the feed will follow time entry logic (time of comment/post)

"Mattias" in this case wrote an comment on 14.50. Then five more wrote comments after him (14.55, 15.15 and so on)

But maybe you are thinking it should be a grey box on top or something? Like when something is shared or error messages? This is not the case for feed messages, ni top box. But please clarify if I'm misunderstanding you again.

  1. Ah now I understand you @samitalalchan ! Well put and phrased! Let's do this easy rule:

    • the participant can not make rides earlier than the time that is right now BUT can get around this by setting a flexible time. -That would mean that the particpant can set the exact time that is right now (if the scenario is that "I'm going right now") and a flexible time to still appear in the feed and in search.
  2. Admin (enabler) can delete everything

    • Participant can delete her own entrys (everything)
samitalalchan commented 6 years ago

@MattiasJay so sorry for confusing you. Actually what we have been doing right now is when you click on the message on Messages and Group screen as Gopal Damauli - Pokhara You will be redirected to the Damauli - Pokhara ride and there will be top messages as Gopal commented on this ride. In order to clarify i am attaching the screenshot :).

screenshot_20180219-151740

screenshot_20180219-151754

So, my question is what should be done in case of bundle. when the message in message and search screen reads. Gopal + 5 Damauli - Pokhara Shall we show the same text as Gopal + 5 others interectacted on this group, Something like that). Or you have some other suggestion. Or we dont need to show the top messages in all the cases. Hope this is clear now :)

MattiasJay commented 6 years ago

Hi again. First I got you but then now you said "search screen" as well?

Anyhow, I think you didn't mean search screen right?

As I thought, you are using the grey box for comments. This is wrong. It should just go to the group and/or ride and scroll down to the comments.

Have you looked at how the Telegram app does it with new messages? It's a little bit highlighted with a "new messages" line that then disappears. Facebook does something similar but with a brief yellow in the background that disappears. Something like this is very intuitive; 1) click, 2) automatically scroll to new 3) highlight in some way.

Any suggestions on this @samitalalchan @anjesh @anjhero ?

samitalalchan commented 6 years ago

@MattiasJay Ok i get it now. We will do research on the last options Something like this is very intuitive; 1) click, 2) automatically scroll to new 3) highlight in some way. and get back to you.

MattiasJay commented 6 years ago

Awesome @samitalalchan ! You are very good at asking good questions so keep the questions coming. It feels like for every question you ask we make the app better and better. This is going to be awesome!

samitalalchan commented 6 years ago
  1. IF adding participant from contact THIS will happen:
    • IF this participant joins the movement (creates an account) THEN she will be automatically added to the group
    • But no nothing more; they will not get any notifications if they haven't joined (notifications are only in-app for verified participants)

We can automatically add the user if he joins the movement(creates an account) as told by you, but I think it will be better if we send an sms or email while adding participants from contact. By doing so it will help us to spread the word about the app and also because the user from contact will never know the fact that his friends uses the app and has added him in his group and wants him to join the movement. What do you think @MattiasJay ?

MattiasJay commented 6 years ago

Oh, I see we have an misunderstanding @samitalalchan :-)

I thought you meant that they will get notifications from the group, even if they haven't downloaded the app, as SMS messages.

What you're saying now is correct; every time I share something with my phone contacts and/or add them to a group and they're not using the app they will get an SMS message. Yes.

shresthaKiran commented 6 years ago

This issue has been resolved.