Training: How to prepare a release

Sklore commented 7 years ago

Hi Team,

With my availability decreasing not increasing I figure I should teach someone else how to prepare and request a release.

Focus on closing out as many bugs as possible and completing any new content releases
Test a clean install of the community pack to ensure no errors are generated.
Prepare the change log. I do this by updating a wiki entry. This is why you should always include a description of the change in your commits. There is a way to see a list of commits since the last update. Notes: https://github.com/Sklore/HL_DD_5e_Colab/wiki/3.-Pending-Changes List of Commits since last release (13/02/17) https://github.com/Sklore/HL_DD_5e_Colab/commits/master?after=0c795876caf5a6f0068c853394a114750509fe89+69
Raise issue in the Github and tag . Shadow runs and manages the server that hosts the Community Pack.
Shadow will complete the update and advise once its completed
Test it to ensure no errors.
Post an update to the Community Pack forum to advise of the update and note the changes. http://forums.wolflair.com/showthread.php?t=55090

I'm here for any questions.

Sklore commented 7 years ago

I have updated the Pending Changes in preparation for a 1.9 Release. @TheEnthusiast; @DarkHayZe, @furby076

Please review and let me know if there us anything that needs completing prior to release. Is the Mystic done? I can see ALOT of work has gone into that.

furby076 commented 7 years ago

Let me check in.an updated file tonight, plus any outstanding items. Really the remaining changes are medium priority (can we show max power points per power next to the spell points tab in spells). The build is solid, and will put a smile on anyones face. The only major component left is trimming the text by 20%. That will take me a while to do alone

furby076 commented 7 years ago

Attached is the latest. 7/23 COM_5ePack_UA - Mystic v3.zip

Below are the outstanding items

Below are the open items: General

Psionic Mastery: Is it possible to combine both scripts so it shows the max usage, and max points in one In Play
Psi Limit: Can Psi limit (per power) be shown on spells tab, or somewhere?

Discipline Focus

Master of Water: How to make swim speed appear in the Basics
Precognition: Advantage on initiative does not fully work
Psychic Assault: This probably can't work. It's +2 to psionic talents

~~Order of Awakened

Spectral Form: How to make it halved speed

Order of Immortal

Psionic Resilience: Need script to give perm Temporary hit points = intelligence modifier

Nomad Abilities

Skills and tools take aways picks from languages (this is good); however languages do not take away picks from skills and tools (this is the bad)
Languages are showing all languages, including ones you already have chosen with the exception of any background languages; I suppose this isn't a huge issue, but it would be nice to fix

TheEnthusiast commented 7 years ago

Hi,

The attached file breaks my instalation. It acuses that wSoulKnife thing does not exists. It is bootstrapped from c5CSoul.

Aside from that, I've noticed that you make the level checks with xAllLev. As far as I know, this is bad because it measures your character level, not your class level. Have you tested multiclass builds ?

Psionic Mastery: Is it possible to combine both scripts so it shows the max usage, and max points in one In Play

Use the traker for the once a day part and add a second pool for the points.

Psi Limit: Can Psi limit (per power) be shown on spells tab, or somewhere?

Have you tried with the "Choose ammount of activation" button?

Master of Water: How to make swim speed appear in the Basics

Just grant the hero xSwim . See the mariner fighting style for an example.

Psychic Assault: This probably can't work. It's +2 to psionic talents

You could add a condition to add extra text to every bootstrapped spell, but probably is overkill. On the bright side, it's a bonus, players almost never forget those.😂

Avatar of Battle: Provides +2 initiative at level 3. However, it's giving it at every level. Need to fix

You put it on First phase, try changing to post level. You might need to add a levelcount[Class] condition.

Spectral Form: How to make it halved speed

Add a check for the Active flag, in a post level phase. Then, halve the hero speed.

Psionic Resilience: Need script to give perm Temporary hit points = intelligence modifier

You need to add a THP pool. See https://github.com/Sklore/HL_DD_5e_Colab/wiki/Adding-Temporary-Hit-Points

I believe there's a new pool object to be used instead of PoolWlkBls

Skills and tools take aways picks from languages (this is good); however languages do not take away picks from skills and tools (this is the bad)

From the file (thing id="cfg5CNomad"):

~ Total up all the skills and tools that have been chosen field[cPhaStart].value += field[cSkillCur].value + field[cToolCur].value

Add field[cfgLaMax1].value to the sum.

Also, you have a minus here:

field[cfgLaMax1].value -= field[cPhaStart].value

Languages are showing all languages, including ones you already have chosen with the exception of any background languages; I suppose this isn't a huge issue, but it would be nice to fix

You need to set cfgLaAllo1 with a regex between component.BaseLang and negate all SpeakLang.* tags on the hero.

I'm currently short on time and resources (computer burned), so if someone point me out what I have pending I can send directions on how to fix.

Cheers

2017-06-19 20:02 GMT-03:00 furby076 notifications@github.com:

Attached is the latest. COM_5ePack_UA - Mystic v3.zip https://github.com/Sklore/HL_DD_5e_Colab/files/1086552/COM_5ePack_UA.-.Mystic.v3.zip

Below are the outstanding items

Below are the open items: General

Psionic Mastery: Is it possible to combine both scripts so it shows the max usage, and max points in one In Play

Psi Limit: Can Psi limit (per power) be shown on spells tab, or somewhere?

Discipline Focus

Master of Water: How to make swim speed appear in the Basics

Precognition: Advantage on initiative does not fully work

Psychic Assault: This probably can't work. It's +2 to psionic talents

~~Order Of Avatar

Avatar of Battle: Provides +2 initiative at level 3. However, it's giving it at every level. Need to fix

~~Order of Awakened

Spectral Form: How to make it halved speed

Order of Immortal

Psionic Resilience: Need script to give perm Temporary hit points = intelligence modifier

Nomad Abilities

Skills and tools take aways picks from languages (this is good); however languages do not take away picks from skills and tools (this is the bad)

Languages are showing all languages, including ones you already have chosen with the exception of any background languages; I suppose this isn't a huge issue, but it would be nice to fix

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Sklore/HL_DD_5e_Colab/issues/677#issuecomment-309597325, or mute the thread https://github.com/notifications/unsubscribe-auth/ATY-fAZo-c5OIwCc8Xz1W8rIQnD1N5oUks5sFv31gaJpZM4Nzaa1 .

-- Men cry not for themselves, but for their comrades.

LOVELESS

furby076 commented 7 years ago

Hey Enthusiast, I appreciate the list. If you have time, when your computer is fixed, would you be able to assist me? Honestly, I am not that good at the coding, and with the others mainly focused on doing the grunt work.

I will try working the list as best as possible but can use the help.

Master of water: After making the changes, swim speed appears in special, but not next to normal speed in "Basics"

Darkhayze fixed Soul KNife

Good luck on the computer

furby076 commented 7 years ago

Avatar of Battle +2 initiative is working

furby076 commented 7 years ago

Class should now be multi-classible. Changed all instances of calculating based on xLev to calculate based on the Mystic class

COM_5ePack_UA - Mystic v3.zip

Defect list is included in the zip (nicer formatting).

furby076 commented 7 years ago

@TheEnthusiast - updates made to avatar of battle, soul knife, changed calculations based on mystic level. Let me know what you think

furby076 commented 7 years ago

Any thoughts?

Churchill92 commented 7 years ago

Are we good for a release now?

furby076 commented 7 years ago

I think so. There are some minor issues, but I think the general community could help. The classes are totally playable

Churchill92 commented 7 years ago

What needs final testing before going out then?

furby076 commented 7 years ago

Not so much final testing. There are open items that I don't know how to program. These are not game breaking things and will require manual tracking (like many other components in the tool). COM_5ePack_UA - Mystic v3.zip

Below are the open items: Below are the open items: General

Psionic Mastery: Is it possible to combine both scripts so it shows the max usage, and max points in one In Play
Psi Limit: Can Psi limit (per power) be shown on spells tab, or somewhere?

Discipline Focus

Master of Water: How to make swim speed appear in the Basics
Precognition: Advantage on initiative does not fully work
Psychic Assault: This probably can't work. It's +2 to psionic talents

~~Order of Awakened

Spectral Form: How to make it halved speed

Order of Immortal

Psionic Resilience: Need script to give perm Temporary hit points = intelligence modifier

Nomad Abilities

Skills and tools take aways picks from languages (this is good); however languages do not take away picks from skills and tools (this is the bad)
Languages are showing all languages, including ones you already have chosen with the exception of any background languages; I suppose this isn't a huge issue, but it would be nice to fix

LordMorin commented 7 years ago

I thought I'd take a shot at fixing your scripting issues, however when I install the script I get 2 error messages dealing with:

"Thing 'c5CSould' - Bootstrap thing 'wSoulKnife' does not exist"

Then, of course, none of the custom files show up.

furby076 commented 7 years ago

Hmmm...OK i think i may have found a lead. Give me a few minutes

LordMorin commented 7 years ago

I'm using the one you linked in this posting.

I am going to remove my own version of the Mystic in case it is conflicting with the community version.

LordMorin commented 7 years ago

I have just got called away. I'll look into this when I get back.

furby076 commented 7 years ago

Found and fixed the issue. The soulknife line of code was placed into another one of my files. I removed it and put it in this file. It will work now.

COM_5ePack_UA - Mystic v3.zip

LordMorin commented 7 years ago

Ok, started looking at all the changes between v2 & v3. A lot more than I realized. I'll have to go through everything before I start scripting. A lot of the stuff you want is already in my version, I just have to modify my scripts to work with v3.

Psionic Mastery wasn;t in v2 at all, so I have to look at it more carefully before I try to integrate the two scripts together. It should be possible though. The issue will be getting my mind around to your mindsets.

I'll probably do the easy stuff first to get back into the swing of things.

furby076 commented 7 years ago

Thank you so much LordMorin. You're help in making this file better is greatly appreciated! Especially now that Mystic is allowed in AL, we should get a good showing of this

LordMorin commented 7 years ago

My biggest issue at the moment is how you did certain things. :)

Currently I a, trying to figure out where you calculated then inserted the number of psi points you gain at a given level. I found the ability, just not where you are calculating the value. Once I find that I'll know where to insert the Psi Limit.

I'm waiting for a reply from ShadowChemosh on how to covert a field value to a tag value for Mastery of Water swimming speed. I remember using it before but for the life of me I can't remember how I did it.

furby076 commented 7 years ago

Got it. Shadow and Dark helped me with that complex stuff.

PsiPoints are located at: Class -> Class Special -> "psi Points" -> Script

  if (#levelcount[Mystic] >= 1) then
    field[trkMax].value += 2
  endif
  if (#levelcount[Mystic] >= 2) then
    field[trkMax].value += 2
  endif
  if (#levelcount[Mystic] >= 3) then
    field[trkMax].value += 10
  endif
  if (#levelcount[Mystic] >= 4) then
    field[trkMax].value += 3
  endif
  if (#levelcount[Mystic] >= 5) then
    field[trkMax].value += 10
  endif
  if (#levelcount[Mystic] >= 6) then
    field[trkMax].value += 5
  endif
  if (#levelcount[Mystic] >= 7) then
    field[trkMax].value += 6
  endif
  if (#levelcount[Mystic] >= 8) then
    field[trkMax].value += 6
  endif
  if (#levelcount[Mystic] >= 9) then
    field[trkMax].value += 13
  endif
  if (#levelcount[Mystic] >= 10) then
    field[trkMax].value += 7
  endif
  if (#levelcount[Mystic] >= 18) then
    field[trkMax].value += 7
  endif`

There is also a mystic psi point tracker, go to Tracker. Not sure if this still does stuff.

LordMorin commented 7 years ago

That calculates your Psi Limit, what I am looking fir is where you are calculating your actual Psi Points themselves. :)

I THINK it has to do with 1 of 2 new procedures you have, but I have yet to discover where they are actually being used.

furby076 commented 7 years ago

Hm. Maybe I am misunderstanding. The above script calculates the "Psi Points" available for the day. It also shows the DC

The Psi Limit (# of max points to user power) is not listed anywhere

furby076 commented 7 years ago

FOr the two procedures....i think that is legacy code and no longer used. I deleted both procedures and everything is still working properly

LordMorin commented 7 years ago

Master of Water: How to make swim speed appear in the Basics

Now displays a swim speed equal to the hero's walk speed in Special column when selected as Psychic Focus.

What is the issue with precognition? When it is selected as your psychic focus, it does display that you have Advantage when you move your cursor over it?

furby076 commented 7 years ago

Can the "Initiative" listed in "Basics" column get an * next to it? This happens in skills and feats (Check out Deception)

furby076 commented 7 years ago

For Master of Water...same thing. In the Basics column, next to "30 speed" it doesn't display it there.

ghost commented 7 years ago

I opened a ticket with LW for the initiative bug and they sent me an e-mail stating that advantage to init would show properly on the basics tab in the next release. I didn't ask about speed so that may be another ticket needed.

LordMorin commented 7 years ago

Unfortunately not as far as I've been able to discover. You'd have to out in a suggestion with HL for that as a feature.

I could probably set it up so the advantage shows under special when you are focused, but I think that's it.

LordMorin commented 7 years ago

Now form of speed, whether climbing, tunneling, flying, or swimming shows up under basic unfortunately.

furby076 commented 7 years ago

TIckets

Initiative: Well, it looks like INitiative will be fixed in next version - so no need to worry about it now.
Movement (swim): Needs to be opened as a ticket.

General

Psionic Mastery: Is it possible to combine both scripts so it shows the max usage, and max points in one In Play
Psi Limit: Can Psi limit (per power) be shown on spells tab, or somewhere?

Discipline Focus

Master of Water: How to make swim speed appear in the Basics. TICKET needs to be opened
Precognition: Advantage on initiative does not fully work. Ticket is opened
Psychic Assault: This probably can't work. It's +2 to psionic talents

Order of Awakened

Spectral Form: How to make it halved speed

Order of Immortal Psionic Resilience: Need script to give perm Temporary hit points = intelligence modifier

Nomad Abilities

Skills and tools take aways picks from languages (this is good);
however languages do not take away picks from skills and tools
(this is the bad)
Languages are showing all languages, including ones you already
have chosen with the exception of any background languages;
I suppose this isn't a huge issue, but it would be nice to fix

LordMorin commented 7 years ago

Swim speed will at least now show under Special where it wasn't before.

Working on Psychic Assault at the moment.

LordMorin commented 7 years ago

Just accidentally deleted a script due to lack of focus . . .

Fortunately I'd copied ti to notepad first I I recovered it. But it means enough for one night. :)

furby076 commented 7 years ago

Hah. I've done that before. Goodnight, and speak soon. Again, thank you!

furby076 commented 7 years ago

Hey @LordMorin - Hopefully you rested well. any updates?

LordMorin commented 7 years ago

Added Psi Limit to InPlay. Did a re-work of Potent Psionics to work with Psychic Assaut. The new ground work is done, Added a new tag to damaging talents (Custom.5CPsiTDam. This is to differentiate between damaging and non-damaging talents to help with Potent Psionics and Psychic Assault damage modifiers.

Tomorrow I finish that part up by actually applying the damage modifiers to the damaging talents.

Also added Psionic Resilience Temporary Hit Point pool.

furby076 commented 7 years ago

That's awesome. Thank you! Would you please upload what you have done so far?

LordMorin commented 7 years ago

I'll upload, if I can this time, once I get Potent Psionics finished. Hate to upload something incomplete.

ghost commented 7 years ago

What are we waiting on for next release? I uploaded all the monsters and NPCs from VGtM. Are we wanting a specific item to be in this release? I updated the v1.9 prerelease notes to reflect changes and it looks like a good amount of stuff pending release.

LordMorin commented 7 years ago

I'm out of town visiting family for a week to 10 days. I hope to finish up the scripting I aqm working on, but my schedule is unpredictable currently. In addition, my mother has no internet, unthinkable I know, so I only conect when I am over at my sisters. . . .

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, Jul 28, 2017 at 12:21 PM, dungeonguru notifications@github.com wrote:

What are we waiting on for next release? I uploaded all the monsters and NPCs from VGtM. Are we wanting a specific item to be in this release? I updated the v1.9 prerelease notes to reflect changes and it looks like a good amount of stuff pending release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Sklore/HL_DD_5e_Colab/issues/677#issuecomment-318698675, or mute the thread https://github.com/notifications/unsubscribe-auth/AQXxM12_Z0apXGxfd6qLj5evlXlmspo2ks5sSgqkgaJpZM4Nzaa1 .

furby076 commented 7 years ago

Have a blast bud!

Can you upload what you currently have? This will allow the release to be that much more complete

LordMorin commented 7 years ago

I went to try upload the file and realized I hadn't copied it over to my laptop before leaving. I'll have to have my roommate email me a copy so I can even work on it . . .

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, Jul 28, 2017 at 2:11 PM, furby076 notifications@github.com wrote:

Have a blast bud!

Can you upload what you currently have? This will allow the release to be that much more complete

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Sklore/HL_DD_5e_Colab/issues/677#issuecomment-318725036, or mute the thread https://github.com/notifications/unsubscribe-auth/AQXxMzEM-fJGaYoQASdYsmbJz0ytLuxRks5sSiQ_gaJpZM4Nzaa1 .

furby076 commented 7 years ago

@dungeonguru - As soon as LordMorin can get this to us there should be a lot less issues. In this last sprint he managed to clear a couple. I think Psychic assault and potent psionics (not sure whats been done)

TIckets

Precognition: Initiative: Not displaying advantage. Looks like system bug will be fixed in next version
Movement (swim, climb, fly) not displaying in basics next to regular move: Ticket needs to be opened

General

Psionic Mastery: Is it possible to combine both scripts so it shows the max usage, and max points in one In Play

Discipline Focus

Master of Water: How to make swim speed appear in the Basics
Precognition: Advantage on initiative does not fully work. Ticket is opened
Psychic Assault: This probably can't work. It's +2 to psionic talents

Order of Awakened

Spectral Form: How to make it halved speed

Nomad Abilities

Skills and tools take aways picks from languages (this is good); however languages do not take away picks from skills and tools (this is the bad)
Languages are showing all languages, including ones you already have chosen with the exception of any background languages; I suppose this isn't a huge issue, but it would be nice to fix

Completed

Psi Limit: Can Psi limit (per power) be shown on spells tab, or somewhere? -Order of Immortal: Psionic Resilience: Need script to give perm Temporary hit points = intelligence modifier

Churchill92 commented 7 years ago

Are we still waiting on LM or we good for a release now?

furby076 commented 7 years ago

If we release now, and LM updates when he gets back, how long does it take to update the release?

The code, as is, is fine. There are a few things outstanding, but nothing that would make people reasonably complain

ghost commented 7 years ago

I know this is community driven, but my vote would be to target releases at a set interval - maybe a 3 or 4 month cycle to avoid debate dramas. Anything that misses the window either waits till the next one. Allowing only for exceptions like new sourcebooks or major break-fixes, of course.

Churchill92 commented 7 years ago

My thoughts:

Release cycle - Once a quarter. Full release with all the new content and any updates
Maintenance release - monthly or as required for ground breaking bugs. We can patch any content and material into a patch release .

Rehash on releases (Some of you who are devs this may be old hat) and nomenclature. This is a guideline and open to question, comments, or concerns:

X.Y.Z

X = New Version - 5e.5, wotc changes to a d6 mechanism, 5e modern, something that shakes the foundation of the basic gaming system and schedule we are doing. Once a year or when something large happens that all hands are needed to fix, update, patch, etc.

Y. Major Release - Quarterly, New UA content, new 3rd party content, patches that took longer to fix in the minor releases

Z. Minor Release - As required (monthly or on emergency) to fix small problems, emergency break/fix, or updating current content for clarity or text. This updates the current release of Y.

Let's look at a this in Example where we are now.

1.9.0 X.Y.Z

X=1 We are at the first major release of 5e content. No earth shaking code changes. Full release for base 5e

Y = 9 This is our 9th release of full content patching and release of additional content from upstream or 3rd party.

Z = 0 We haven't patched anything or hand any minor updates.

What would our new release be:

1.10.0

X = 1 No major design changes to the codebase or rules.

Y = 10. This is our 10th release with new content and patches

Z = 0. No new patches to the release

If users post bugs, we fix them, we update Z to .1,.2,.3 etc. as it comes and we fix them. I am a firm believer in faster and more patch releases than monolithic releases that have patches AND content in them.

I am open to hearing everyone's thoughts and to any adjustments. This is a community at large and a community run project.

Sklore commented 7 years ago

So formal lol... up till now I've just made it up a few seconds before the release goes out 👍

LordMorin commented 7 years ago

I uploaded my work so far tp the wrong section. I am posting it here again.

COM_5ePack_UA - Mystic v3.zip

I am currently sorting out where I was when I left for 2 weeks.

Sklore / HL_DD_5e_Colab

Training: How to prepare a release #677