search

Skn0tt / nextjs-nestjs-integration-example

https://nextjs-nestjs-integration-example.now.sh
156 stars 36 forks source link

Integration with @nest/graphql #32

Closed ArturJS closed 2 years ago

ArturJS commented 2 years ago

Fixes: #30 and #21

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skn0tt/nextjs-nestjs-integration-example/6FgWPtzK5MJYRpvvSyQCDpxEG3a7
✅ Preview: https://nextjs-nestjs-integration-example-git-fork-arturj-646a97-skn0tt.vercel.app

ArturJS commented 2 years ago

@Skn0tt PR is ready for review.

Skn0tt commented 2 years ago

Hi! I reviewed this locally and found that some of the changes broke the /api/randomNumber route. It is unclear to me how that ties in with routing-related changes made by the GraphQL plugin. I see this PR tries to solve two separate concerns (namely to fix #30 and #21). Could you open two separate PRs for them, that make minimal changes? That'd make it a lot easier to review them for me. Currently I just see that it broke things, and I don't have the capacity to look into fixing them myself.