search

Skoice / skoice

Proximity Voice Chat on Minecraft using Discord
https://www.spigotmc.org/resources/skoice-proximity-voice-chat.82861/
GNU General Public License v3.0
62 stars 23 forks source link

Add Folia Support #48

Closed TheShyDolphin closed 1 week ago

TheShyDolphin commented 1 year ago

Added support for Folia.

carlodrift commented 1 year ago

Hey @TheShyDolphin! First off, thanks so much for your contribution to the Skoice project! It's efforts like these that really drive our open source community forward, and I truly appreciate your time and work on this.

The addition of Folia server software support is definitely intriguing and could potentially add a lot of value to our software. We've been keeping an eye on that project for a while and it's great to see it being brought to Skoice.

That said, I do have a small concern with the current implementation. I noticed that the library you've chosen to use is still in beta. While I have no doubt it's capable, this does add a certain level of risk to our project. We need to ensure that Skoice maintains its stability for all users.

In light of this, I suggest we hold off merging this pull request until a stable release of the library is available. In the meantime, let's keep a close eye on that library and jump on it as soon as a stable version is released.

Thanks again for your contribution, and please don't let this deter you from continuing to improve Skoice. Your initiative here is much appreciated!

carlodrift commented 1 week ago

Hey, can you create a new PR on the “dev” branch? There will also be some conflicts to resolve.