search

Skons / hassio-addons

7 stars 4 forks source link

LPG, Autogas doesn't work #27

Closed Dutchy-79 closed 2 years ago

Dutchy-79 commented 2 years ago

When pulling fuel_type lpg it gives you a error that you must use autogas, when using autogas it does the same.

[2022-03-20 17:37:23] INFO : Received payload '{"station_id":3580,"fuel_type":"autogas"}' on topic 'dgp/gas_station' [2022-03-20 17:37:23] ERROR : Unable to process stationid '3580' with fuel_type 'autogas', error: ''autogas''

[2022-03-20 17:44:10] INFO : Received payload '{"station_id":3580,"fuel_type":"lpg"}' on topic 'dgp/gas_station' [2022-03-20 17:44:10] ERROR : Unable to validate payload '{"station_id":3580,"fuel_type":"lpg"}' for gas_station with error: ''lpg' is not one of ['euro95', 'euro98', 'diesel', 'autogas'] Failed validating 'enum' in schema['properties']['fuel_type']: {'enum': ['euro95', 'euro98', 'diesel', 'autogas'], 'type': 'string'} On instance['fuel_type']: 'lpg''

Florian14490 commented 2 years ago

I wanted to open issue also, exact same problem here.

Hope there is a fix for it.

Wxam commented 2 years ago

I think you need to change the Fuel type to autogas, think your problem will be fixed then ;)

Florian14490 commented 2 years ago

Thanks for reply but just like the issue starter. I tried lpg and autogas as fueltype. Same logs error/issue like issue-starter.

So no its not working

Wxam commented 2 years ago

I just found out that mine isn't working either anymore and I use the normal euro95 it gives me errors too, about being unable to publish the payload etc... Think we gotta wait for Skons answer.

BebeMischa commented 2 years ago

Just for reference, here using euro98 works fine.

Florian14490 commented 2 years ago

95 and 98 works fine here also. Also with gps location and lowest price 1 2,3 etc

Awesome Addon. But would be nice for me lpg is also working .

Wxam commented 2 years ago

Hmm I for some reason get a error message since a couple of days for 95.

[2022-03-21 08:58:16] ERROR   : Unable to process payload '{'fuel_type': 'euro95', 'radius': 5, 'latitude': 52.509374787853304, 'longitude': 4.990115761756898, 'to_publish': 6}' with error: ''<' not supported between instances of 'NoneType' and 'float''
[2022-03-21 08:58:16] INFO    : publishing status to mqtt
[2022-03-21 08:58:16] DEBUG   : on_message: received the topic 'homeassistant/sensor/dgp/status/config'
[2022-03-21 08:58:17] DEBUG   : publish_status: Waiting for discovery on topic 'homeassistant/sensor/dgp/status/config'
[2022-03-21 08:58:17] DEBUG   : publish_status: Autodiscover 'True', State 'True' and Attributes 'True'
[2022-03-21 08:58:17] INFO    : publishing status done

Haven't changed anything in the last couple of days on the addon it just stopped working all of the sudden.

BebeMischa commented 2 years ago

Do I see same unwanted spaces in your payload, @Wxam ?

Wxam commented 2 years ago

Do I see same unwanted spaces in your payload, @Wxam ?

image

This is my Automation with the payload_template in it. I did a copy paste from the installation document itself just changed person.skons to zone.home and the to_publish to 6

Dutchy-79 commented 2 years ago

@Wxam that looks like a different error to me, maybe make a separate issue for this.

Wxam commented 2 years ago

@Wxam that looks like a different error to me, maybe make a separate issue for this.

Will do that! thanks for the suggestion

EDIT: Link to my issue: https://github.com/Skons/hassio-addons/issues/28

Skons commented 2 years ago

LPG was not correctly implemented, with 2022.3.21.1 there is better support for LPG, autogas should not be used as fueltype in the payload. If there are any issues please let me know.

Florian14490 commented 2 years ago

Kevin, nice. Thanks for the fix. I dont see the update to new version. Or do I have to copy manual the updated files in right folder using samba share?

Skons commented 2 years ago

It can take a while, but if you want to force the update: go to addons in ha, click on “add-on store”, click the hamburger menu at the top and select “check for updates”. The update should be available now

Florian14490 commented 2 years ago

Oh, thats a lot faster haha, I just removed addon and repositry and installed it back. Then he get also the new files.

Dutchy-79 commented 2 years ago

Thanks, works fine for me now.

Florian14490 commented 2 years ago

Kevin, nice. Thanks for the fix. I dont see the update to new version. Or do I have to copy manual the updated files in right folder using samba share?

Outlook voor Androidhttps://aka.ms/AAb9ysg downloaden

From: Kevin Temming @.> Sent: Monday, March 21, 2022 8:41:28 PM To: Skons/hassio-addons @.> Cc: Florian14490 @.>; Comment @.> Subject: Re: [Skons/hassio-addons] LPG, Autogas doesn't work (Issue #27)

LPG was not correctly implemented, with 2022.3.21.1 there is better support for LPG, autogas should not be used as fueltype in the payload. If there are any issues please let me know.

— Reply to this email directly, view it on GitHubhttps://github.com/Skons/hassio-addons/issues/27#issuecomment-1074341265, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUE3NL6B2QTCKZPRCGA6DIDVBDGGRANCNFSM5RFXN2TQ. You are receiving this because you commented.Message ID: @.***>

Skons commented 2 years ago

What is the version you are currently running? Go to settings -> Addons -> Dutch Gas Prices and on the top you can see Current Version