search

Skouat / ext_paypal_donation

This extension add a PayPal Donation page on phpBB
http://skouat.github.io/ext_paypal_donation/
GNU General Public License v2.0
11 stars 8 forks source link

Add manual transaction form #66

Closed kasimi closed 5 years ago

kasimi commented 5 years ago

This PR adds an Add button at the bottom of the Transactions Log page in the ACP, which leads to a form where you can add a transaction manually.

I'm happy to implement any feedback you might have. :smiley:

manual_transaction

Skouat commented 5 years ago

@kasimi This is a functionnal feedback. Currently we are able to add a MT with an amount of 0. I think this should not be allowed. And what about the MT entered with a fee upper than the donation?

kasimi commented 5 years ago

I was wondering about negative donation amounts too. Then I thought, by adding a negative amount, the admin would be able to add debts to a user. The user would then send a real donation to settle up. If you think it's not worth having, I'll add a check, but personally I don't see a reason why it shouldn't be allowed. It won't break the extension (I hope :grin:).

Skouat commented 5 years ago

I was wondering about negative donation amounts too. Then I thought, by adding a negative amount, the admin would be able to add debts to a user. The user would then send a real donation to settle up. If you think it's not worth having, I'll add a check, but personally I don't see a reason why it shouldn't be allowed. It won't break the extension (I hope 😁).

Currently, PPDE doesn't support negative value/refund. For example, if you sent a negative donation, the user will not be removed from the donors group.

kasimi commented 5 years ago

All your feedback is implemented, please have another look. :+1:

Skouat commented 5 years ago

Thanks! I'll review all this friday (not available before). I'll not boring you with the duplicate code, the code complexity... 😉

Skouat commented 5 years ago

Please can you add the following French translation to this PR ?

https://gist.github.com/Skouat/85258630b90fd73752b1982fb6100a03 https://gist.github.com/Skouat/c41af93b35a058d18e10e9a0475a255c

Tkx

Skouat commented 5 years ago

Based on your last commit, I updated the acp_transactions FR language file https://gist.github.com/Skouat/85258630b90fd73752b1982fb6100a03

Skouat commented 5 years ago

Thanks for this PR 😉