Skretzo / runelite-plugins

BSD 2-Clause "Simplified" License
5 stars 10 forks source link

Line markers #51

Open chocobo-s opened 2 months ago

chocobo-s commented 2 months ago

possible to add line markers as a shift command, where you can only add lines when holding shift just like tile markers because if you missclick adding a line when you don't want to and then start clicking or scrollwheel, even deleteing the line breaks the plugin, you can't add more lines and it also breaks the camera as scrollwheel is how you change direction of the line you're adding.

Skretzo commented 2 months ago

You can already add line markers by holding down shift, right-clicking a tile and selecting Add line.

Can you explain a bit more in detail how the plugin broke for you or maybe provide a video of it happening? You need to release the shift key to be able to rotate the camera again. Are you deleting the line in the panel or using shift right-click Remove line?

Wexxorz commented 2 months ago

Hello Skretzo, i've spended over 70hours adding line marker around all the multi areas in runescape. I was doing them 1 zone at a time then I was exporting them in a .txt files. Today, I finally finished every zones :) !! I tryed to upload all 72zones 1 copy paste at a time...Runelite was super slow at the end but did not crash.... When I closed my runelite it only keept 22/72zones... Any idea what can cause that? can I go drop them Manually in a folder somewhere? it looks like they are saved locally?

If you have time, add me on discord : wexxorz

Skretzo commented 2 months ago

You can add them manually, but I'm not sure if that will fix the lag and disappearing markers as this plugin is not really made to support very large amounts of markers. The markers are saved in a .properties file in your .runelite/profiles or .runelite/profiles2 folder (right click screenshot icon to open the folder) and you can paste the text after the = in the line linemarkers.markers=.

Wexxorz commented 2 months ago

I copied pasted Zeah....wich is 671 062 caracters LOL, saved the .properties > Launched runelite, nothing happens, it created a .properties.bak... any others idea :)? I feel like it wont support the 2millions caracters... and i've lost 70hours haha

Skretzo commented 2 months ago

How are you pasting it? It needs to start with [ and end with ]. If you want to give me the file I can try myself. You should be able to drag and drop upload it here in a comment.

Wexxorz commented 2 months ago

Z-ALL.txt That's the Zeah Only File, if you wanna try Thanks alots btw for ur fast responce!! :)

Skretzo commented 2 months ago

I think it worked for me: image

Wexxorz commented 2 months ago

when I close runelite and I open it back that's when everything get wiped. is it the same for you?

Skretzo commented 2 months ago

It is still there and not wiped for me after I close RuneLite and restart

Skretzo commented 2 months ago

How big is your *.properties file. For me it was about 140 kb before and 830 kb after. If your file is much bigger it might be too much for RuneLite. Also try turning off as many other plugins as possible because that might help (I only play with like 10 plugins at most)

Wexxorz commented 2 months ago

its at 1.1kb if I upload zeah it goes to 1.8k and if I upload Gielinor I assume its an extra .9-1k

Skretzo commented 2 months ago

The plugin was very slow to start for me with the zeah markers you gave me (took about 4 seconds) so with more markers I am not sure if it will work. I will try to look at some optimizations, but I sadly don't know of a quick fix.

Wexxorz commented 2 months ago

I finally managed to import both ingame (Zeah/Gielinor) and export them in a single .txt file. As long as I dont close my runelite, I will keep them.

It makes my game super laggy/unplayable haha. I feel like id have to optimized it alots so it could be used.

Skretzo commented 2 months ago

@Wexxorz Could you please send me your client.log file located in the .runelite/logs folder? I would like to look for error messages in that file related to the Line Markers plugin.

Skretzo commented 2 months ago

@Wexxorz have you tried the Multi Lines plugin from the hub? I think that plugin should have the multi lines you have mapped down and that plugin hopefully has better performance.