search

Skretzo / shortest-path

Pathfinding for Old School RuneScape
BSD 2-Clause "Simplified" License
14 stars 31 forks source link

Refactor path handling & fix 'Set Start' (rebased) #11

Closed cyberlarino closed 2 years ago

cyberlarino commented 2 years ago

@Skretzo rebased commits. most notable change is that i removed looking up levels inside Path, instead adding the levels to PathfinderConfig, which is used in constructor whenever a new PathfinderTask is constructed.

cyberlarino commented 2 years ago

Resolves #8

cyberlarino commented 2 years ago

@Skretzo could you open a development branch? if 'master' is what the live version of the plugin is loading from, it would be nice to have a development branch so that changes like these can be merged without having to worry

then we keep pushing onto it, and when it's ready for merging to the live version (1.9), we could merge everything at once instead, once we know it's stable

Skretzo commented 2 years ago

@cyberlarino Changes applied to the master branch will not go live without an additional step that I will have to perform myself, which is to PR the latest commit hash to the runelite/plugin-hub repository. Then, all the changes since the last version of the plugin will be reviewed by trusted RuneLite developers before it is merged into the live client. So whether we use the master branch or create a new branch really does not matter.

cyberlarino commented 2 years ago

Hello sorry I realized afterwards that there is a bug in this, so paths are calculated somewhat wrong. Been hit with COVID so didn’t have the chance to fix it, could you revert and I’ll update the PR with fix?

Skretzo commented 2 years ago

@cyberlarino I have hopefully fixed any issues with this PR in https://github.com/Skretzo/shortest-path/commit/6150e34bfc1e64beaba37874e62685d1c07d986a. I also did some reorganization so this will cause some conflicts for your local branches if you eventually plan on PRing those.

cyberlarino commented 2 years ago

Ah great. 👍